Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apply a thread safe lock over dataloaders #1838

Merged

Conversation

samuelAndalon
Copy link
Contributor

📝 Description

apply a synchronized lock over data loaders, the reactive stack could cause multiple threads trying to access to the same memory.

🔗 Related Issues

#1837
#1819

Verified

This commit was signed with the committer’s verified signature.
rbuckton Ron Buckton
@samuelAndalon samuelAndalon merged commit 3903664 into ExpediaGroup:master Sep 11, 2023
@samuelAndalon samuelAndalon deleted the feat/synchronized-data-loader branch September 11, 2023 22:59
samuelAndalon added a commit to samuelAndalon/graphql-kotlin that referenced this pull request Sep 11, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
### 📝 Description
apply a synchronized lock over data loaders, the reactive stack could
cause multiple threads trying to access to the same memory.

### 🔗 Related Issues
ExpediaGroup#1837
ExpediaGroup#1819
samuelAndalon added a commit that referenced this pull request Sep 12, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
cherry pick #1838
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants