update to Kotlin 1.8 #1822
Merged
update to Kotlin 1.8 #1822
+266
−286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Kotlin version to 1.8.22
dariuszkuc
commented
Aug 23, 2023
| } | ||
| implementation(libs.ktor.client.content) | ||
| implementation(libs.slf4j) | ||
| testImplementation(projects.graphqlKotlinClientJackson) | ||
| testImplementation(projects.graphqlKotlinClientSerialization) | ||
| testImplementation(libs.wiremock.jre8) | ||
| testImplementation(libs.compile.testing) | ||
| testImplementation(libs.compile.testing) { | ||
| // there is no kotlin compile testing release supporting kotlin 1.8.22 |
There was a problem hiding this comment.
This is a workaround that should be removed once compatible version is available. Currently there is no release of kotlin-compile-testing that is compatible with kotlin version 1.8.22 :(
- kotlin 1.8 compatible version is broken for compiler plugins (which we use) due to missing argument
- we need version compatible with kotlin 1.8.20+ that includes a fix for a reflection bug
- kotlin 1.9 compatible version fixes above issues .... but
kotlin-serializationJARs are no longer published with shaded dependencies and we can no longer resolve theSerializationComponentRegistrar
Since there were no breaking API changes in the compile-testing library between the 1.8.22 and 1.9.0 versions, the simplest workaround for now is to explicitly exclude transitive compiler dependencies and explicitly include compatible versions.
|
Large number of changed files is due to |
samuelAndalon
approved these changes
Aug 23, 2023
This was referenced Aug 24, 2023
|
Note: we need to use Kotlin 1.8.20+ due to https://youtrack.jetbrains.com/issue/KT-53279 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Update Kotlin version to 1.8.22
🔗 Related Issues