feat(batching): avoid calculating document ast height in advance #1800
+47
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelAndalon
changed the title
tapaderster
approved these changes
Jun 18, 2023
tapaderster
reviewed
Jun 18, 2023
...oup/graphql/dataloader/instrumentation/level/DataLoaderLevelDispatchedInstrumentationTest.kt
Outdated
Show resolved
Hide resolved
samuelAndalon
added a commit
to samuelAndalon/graphql-kotlin
that referenced
this pull request
Jun 19, 2023
…ediaGroup#1800) Batching by LEVEL requires to calculate the height of all graphql documents in a batch request to be calculated before deciding of a certain level was dispatched, the reason is because a batch request could contain multiple and potentially different operations, with different levels, so, to decide if a level was dispatched, we need to know which operations in the batch request share the same level. This PR will remove that logic, which was take it from the graphql-java [MaxDepthInstrumentation](https://github.com/graphql-java/graphql-java/blob/master/src/main/java/graphql/analysis/MaxQueryDepthInstrumentation.java#L56). Instead we will calculate the height on runtime, simplifying the dispatch by level instrumentation and removing some CPU usage by not doing an AST traversal to calculate height.
samuelAndalon
added a commit
that referenced
this pull request
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Batching by LEVEL requires to calculate the height of all graphql documents in a batch request to be calculated before deciding of a certain level was dispatched, the reason is because a batch request could contain multiple and potentially different operations, with different levels, so, to decide if a level was dispatched, we need to know which operations in the batch request share the same level.
This PR will remove that logic, which was take it from the graphql-java MaxDepthInstrumentation.
Instead we will calculate the height on runtime, simplifying the dispatch by level instrumentation and removing some CPU usage by not doing an AST traversal to calculate height.