feat: GraalVM native image support for Spring server #1769
Merged
+696
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to enable GraalVM native image support for `graphql-kotlin-spring-server`.
dariuszkuc
added
changes: minor
dariuszkuc
commented
May 3, 2023
| @@ -34,7 +34,7 @@ class GenerateGraalVmMetadataMojo : AbstractSourceMojo() { | |||
| override lateinit var outputDirectory: File | |||
|
|
|||
| override fun generate() { | |||
| val metadataDirectory = File(outputDirectory, "META-INF/native-image/${project.groupId}/${project.name}") | |||
| val metadataDirectory = File(outputDirectory, "META-INF/native-image/${project.groupId}/${project.name}/graphql") | |||
There was a problem hiding this comment.
GraalVM plugin looks for reachability metadata under any META-INF/native-image subdirectories. Per GraalVM documentation they suggest to generate reachability metadata under <groupId>/<artifactId> subdirectory to avoid collisions. Adding explicit graphql subdirectory to avoid collision with SpringBoot plugin generating metadata under the same directory.
dariuszkuc
commented
May 3, 2023
| @@ -29,13 +30,21 @@ data class GraphQLConfigurationProperties( | |||
| val packages: List<String>, | |||
| /** Boolean flag indicating whether to print the schema after generator creates it */ | |||
| val printSchema: Boolean = false, | |||
| @NestedConfigurationProperty | |||
There was a problem hiding this comment.
required extra metadata to generate GraalVM native image (docs)
dariuszkuc
commented
May 3, 2023
| @@ -1,5 +1,10 @@ | |||
| import java.util.Properties | |||
|
|
|||
| @Suppress("DSL_SCOPE_VIOLATION") // TODO: remove once KTIJ-19369 / Gradle#22797 is fixed | |||
| plugins { | |||
| alias(libs.plugins.graalvm.native) apply false | |||
There was a problem hiding this comment.
GraalVM native plugin dynamically generates some "helper" methods so we need to ensure they are generated just once for whole composite project, otherwise build blows up with classpath issues.
Apply same change to Gradle (use `graphql` subdirectory) as was done for Maven. SpringBoot JAR complains about duplicate resources otherwise...
samuelAndalon
approved these changes
May 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Changes to enable GraalVM native image support for
graphql-kotlin-spring-server.🔗 Related Issues