feat: FederatedTypePromiseResolver to settle all promises regardless of errors #1753
+223
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariuszkuc
reviewed
Apr 18, 2023
...om/expediagroup/graphql/generator/federation/extensions/CompletableFutureExtensionsKtTest.kt
Show resolved
Hide resolved
dariuszkuc
reviewed
Apr 18, 2023
...tlin/com/expediagroup/graphql/generator/federation/extensions/CompletableFutureExtensions.kt
Show resolved
Hide resolved
tapaderster
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
the
FederatedTypePromiseResolverwas originally created with theDataLoaderuse case in mind, meaning that all returnedCompletableFutures are resolved synchronously, to letDataLoaderdispatch mechanism to decide when to dispatch, so realistically, when usingDataLoaders, there is not an scenario where a particularCompletableFuturemight complete exceptionally.However, nothing stops users to use the
FederatedTypePromiseResolverwithout dataloaders, which means that nowCompletableFutures might complete exceptionally in a asynchronous way.To solve that, create allSettled extension function
which will complete all promises even if one or more complete exceptionally. The type of each element in the returned list will be a kotlin Result that encapsulates a successful outcome with a value of type
Tor a failure with the exception.🔗 Related Issues
#1747