Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update graphql-java version #1749

Merged

Conversation

samuelAndalon
Copy link
Contributor

@samuelAndalon samuelAndalon commented Apr 15, 2023

📝 Description

update graphql-java from 19.2 to 20.2

https://github.com/graphql-java/graphql-java/releases/tag/v20.0
https://github.com/graphql-java/graphql-java/releases/tag/v20.1
https://github.com/graphql-java/graphql-java/releases/tag/v20.2

graphql-java 20.0 introduces Lightweight Data Fetchers under the LightDataFetcher interface, which will avoid creating a DataFetchingEnvironment instance each time the execution engine attempt to resolve a property using the PropertyDataFetcher.

updates federation-jvm to 3.0.0

@samuelAndalon samuelAndalon mentioned this pull request Apr 16, 2023
*/
class PropertyDataFetcher(private val propertyGetter: KProperty.Getter<*>) : TrivialDataFetcher<Any?> {
class PropertyDataFetcher(private val propertyGetter: KProperty.Getter<*>) : LightDataFetcher<Any?> {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PropertyDataFetcher will now implement the LightDataFetcher, which will make the execution engine to create the dataFetchingEnviroment on demand, most (if not all), PropertyDataFetchers dont require this field, so this will represent a memory improvement

@dariuszkuc dariuszkuc added the changes: major Changes require a major version label Apr 17, 2023
@samuelAndalon samuelAndalon added the type: dependency changes Dependency change which doesn't affect our library usage label Apr 17, 2023
@samuelAndalon samuelAndalon merged commit 4d25331 into ExpediaGroup:master Apr 18, 2023
@samuelAndalon samuelAndalon deleted the chore/update-graphql-java branch April 18, 2023 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes: major Changes require a major version type: dependency changes Dependency change which doesn't affect our library usage
Development

Successfully merging this pull request may close these issues.

None yet

2 participants