Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GraalVM example integration #1742

Merged
merged 1 commit into from
Apr 11, 2023
Merged

GraalVM example integration #1742

merged 1 commit into from
Apr 11, 2023
+1,053 −1

Conversation

dariuszkuc
Copy link
Collaborator

@dariuszkuc dariuszkuc commented Apr 10, 2023 •
edited
Loading

📝 Description

Adds new graalVM composite build that ensures servers (ktor for now) can be build with GraphQL Kotlin plugin and produce valid GraalVM native image.

🔗 Related Issues

@dariuszkuc dariuszkuc force-pushed the graal_wip branch 2 times, most recently from 3a3f240 to 537327d Compare April 11, 2023 14:25
@dariuszkuc
GraalVM example integration

Verified

This commit was signed with the committer’s verified signature.
Josh-Cena Joshua Chen
GPG key ID: C37145B818BDB68F
Verified
Learn about vigilant mode
01a1345 
Adds new `graalVM` composite build that ensures servers (ktor for now) can be build with GraphQL Kotlin plugin and produce valid GraalVM native image.
@dariuszkuc dariuszkuc changed the title graalvm gradle plugin task GraalVM example integration Apr 11, 2023
@dariuszkuc dariuszkuc marked this pull request as ready for review April 11, 2023 20:03
@dariuszkuc
Copy link
Collaborator Author

Few notes:

  • cannot use nativeTest task directly as it is unaware of the generated metadata files - we should revisit the implementation later so we could just run the same unit tests as for regular build
  • I am not using nativeRun task directly because it takes a long time to build native image and we would need to add some custom polling to ensure app is up before running the integration (we need to start the server in the background to be able to run some tests against it)

@dariuszkuc dariuszkuc enabled auto-merge (squash) April 11, 2023 20:07
@samuelAndalon samuelAndalon self-requested a review April 11, 2023 21:17
@dariuszkuc dariuszkuc merged commit 2902678 into ExpediaGroup:master Apr 11, 2023
@dariuszkuc dariuszkuc deleted the graal_wip branch April 11, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelAndalon samuelAndalon

Assignees

@samuelAndalon samuelAndalon

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dariuszkuc @samuelAndalon