feat: new GraalVM reflect metadata generator #1739
Merged
+1,893
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creates new `graphql-kotlin-graalvm-metadata-generator` project that will be used by Gradle and Maven plugins to auto-generate GraalVM reachability metadata. In order to keep the size of PRs manageable, plugin PRs will be created separately. [GraalVM reachability metadata](https://www.graalvm.org/22.2/reference-manual/native-image/metadata/) is required by GraalVM to support reflections and resource handling. This feature will be used by plugins as way to simplify running `graphql-kotlin` servers as GraalVM native images. Without this functionality, end users have to start their applications with GraalVM agent and then manually run **ALL** possible execution paths (i.e. queries, loading graphiql, etc).
dariuszkuc
commented
Apr 6, 2023
| @@ -53,6 +54,7 @@ project(":graphql-kotlin-client-generator").projectDir = file("plugins/client/gr | |||
| project(":graphql-kotlin-sdl-generator").projectDir = file("plugins/schema/graphql-kotlin-sdl-generator") | |||
| project(":graphql-kotlin-hooks-provider").projectDir = file("plugins/schema/graphql-kotlin-hooks-provider") | |||
| project(":graphql-kotlin-federated-hooks-provider").projectDir = file("plugins/schema/graphql-kotlin-federated-hooks-provider") | |||
| project(":graphql-kotlin-graalvm-metadata-generator").projectDir = file("plugins/server/graphql-kotlin-graalvm-metadata-generator") | |||
There was a problem hiding this comment.
re: new server directory - this logic didn't make much sense to put under existing schema directory, directory is just used for grouping related modules
maybe we should move schema projects under server functionality? or just keep those separate
dariuszkuc
commented
Apr 6, 2023
...generator/src/main/kotlin/com/expediagroup/graphql/plugin/graalvm/GenerateGraalVmMetadata.kt
Outdated
Show resolved
Hide resolved
dariuszkuc
commented
Apr 6, 2023
...a-generator/src/main/kotlin/com/expediagroup/graphql/plugin/graalvm/DefaultMetadataLoader.kt
Show resolved
Hide resolved
samuelAndalon
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Creates new
graphql-kotlin-graalvm-metadata-generatorproject that will be used by Gradle and Maven plugins to auto-generate GraalVM reachability metadata. In order to keep the size of PRs manageable, plugin PRs will be created separately.GraalVM reachability metadata is required by GraalVM to support reflections and resource handling. This feature will be used by plugins as way to simplify running
graphql-kotlinservers as GraalVM native images. Without this functionality, end users have to start their applications with GraalVM agent and then manually run ALL possible execution paths (i.e. queries, loading graphiql, etc).🔗 Related Issues