Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): pin GraphiQL versions #1735

Merged
merged 1 commit into from
Mar 28, 2023
Merged

fix(server): pin GraphiQL versions #1735

merged 1 commit into from
Mar 28, 2023
+6 −151

Conversation

dariuszkuc
Copy link
Collaborator

📝 Description

  • pin @graphiql/plugin-code-exporter version to ensure GraphiQL won't break when new version is published
  • move graphql-graphiql.html resource to common graphql-kotlin-server module so the same file is used by spring and ktor servers

🔗 Related Issues

Supersedes: #1734

@dariuszkuc
fix(server): pin GraphiQL versions
f49fc43 
* pin `@graphiql/plugin-code-exporter` version to ensure GraphiQL won't break when new version is published
* move `graphql-graphiql.html` resource to common `graphql-kotlin-server` module so the same file is used by spring and ktor servers

Supersedes: ExpediaGroup#1734
@dariuszkuc dariuszkuc added changes: patch Changes require a patch version module: server Issue affects the server code labels Mar 28, 2023
@dariuszkuc dariuszkuc enabled auto-merge (squash) March 28, 2023 20:32
@dariuszkuc dariuszkuc mentioned this pull request Mar 28, 2023
Closed
@samuelAndalon samuelAndalon self-requested a review March 28, 2023 20:34
@dariuszkuc
Copy link
Collaborator Author

NOTE: I did not update graphiql to latest (2.4.0) as it was blowing up with missing some polyfill function

@dariuszkuc dariuszkuc closed this Mar 28, 2023
auto-merge was automatically disabled March 28, 2023 20:34

Pull request was closed

@dariuszkuc dariuszkuc reopened this Mar 28, 2023
@samuelAndalon
Copy link
Contributor

should we just skip integrity checks ?

@dariuszkuc dariuszkuc enabled auto-merge (squash) March 28, 2023 20:34
@dariuszkuc
Copy link
Collaborator Author

should we just skip integrity checks ?

I'd keep those as it ensures that no-one tampers with the referenced resources.

@dariuszkuc dariuszkuc merged commit 56205a0 into ExpediaGroup:master Mar 28, 2023
@dariuszkuc dariuszkuc deleted the pin_graphiql branch March 28, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelAndalon samuelAndalon

Assignees
No one assigned
Labels
changes: patch Changes require a patch version module: server Issue affects the server code
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dariuszkuc @samuelAndalon