[ktor plugin] refactor route configuration #1688
Merged
+210
−205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that it is currently not possible to easily access the previously configured routes. This means that it is not possible to intercept our auto-configured routes to add some additional configuration (e.g. `Authentication`). This PR refactors the plugin to extract all routes into a separate extension functions that can be invoked by the users.
New plugin configuration will consist of 2 steps - (1) configuring server and (2) configuring routes.
```kotlin
fun Application.myGraphQLModule() {
install(GraphQL) {
// all schema, engine and server configuration go here
}
install(Routing) {
// configure routes
graphQLGetRoute()
graphQLPostRoute()
graphQLSDLRoute()
graphiQLRoute()
}
}
```
This refactor follows the same pattern as `Authentication` plugin.
Resolves: ExpediaGroup#1676
dariuszkuc
commented
Feb 26, 2023
| } | ||
| limit { | ||
| counter = "BRANCH" | ||
| value = "COVEREDRATIO" | ||
| minimum = "0.45".toBigDecimal() | ||
| minimum = "0.35".toBigDecimal() |
There was a problem hiding this comment.
drop in coverages is mostly due to the getters/setters of the config unsure if it is worth to write specific tests for those....
samuelAndalon
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
It appears that it is currently not possible to easily access the previously configured routes. This means that it is not possible to intercept our auto-configured routes to add some additional configuration (e.g.
Authentication). This PR refactors the plugin to extract all routes into a separate extension functions that can be invoked by the users.New plugin configuration will consist of 2 steps - (1) configuring server and (2) configuring routes.
This refactor follows the same pattern as
Authenticationplugin.🔗 Related Issues
Resolves: #1676