build: gradle plugin download sdl / introspection integration tests #1656
+2,261
−227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariuszkuc
commented
Jan 24, 2023
| import com.expediagroup.graphql.plugin.gradle.tasks.GraphQLDownloadSDLTask | ||
|
|
||
| plugins { | ||
| kotlin("jvm") version "1.7.21" |
There was a problem hiding this comment.
we could potentially load this from version catalog (but would have to update the test logic to copy the toml file - will look into this later)
|
NOTE: big size of the PR is due to introspection/sdl results (1946 lines changed) copied over for wiremock in the composite build. |
linux is case sensitive, mac is not
samuelAndalon
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Migrate download sdl task and introspection task integration tests to a composite build. Failure scenarios (i.e. timeout) is still run through
GradleRunnerin the plugin project.🔗 Related Issues