update to SpringBoot 3 and Java 17 #1638
Merged
+127
−129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires update to |
dariuszkuc
force-pushed
the
springboot3
branch
3 times, most recently
from
018048f to
e373fa7
Compare
SpringBoot v3 requires Java 17. This PR updates target bytecode of ALL `graphql-kotlin` modules to Java 17 and as a result ibrary users will have to use Java 17+ as well.
dariuszkuc
force-pushed
the
springboot3
branch
from
e373fa7 to
36ad3f7
Compare
dariuszkuc
commented
Jan 27, 2023
| @@ -1,10 +1,10 @@ | |||
| [versions] | |||
| android-plugin = "7.1.2" | |||
| android-plugin = "8.0.0-alpha11" | |||
There was a problem hiding this comment.
AGP version 7.3+ is required for Java 17 support
- v7.3 was failing complaining about incorrect path to generated sources (which were correct)
- v7.4 was failing due to https://issuetracker.google.com/issues/261329823
tapaderster
approved these changes
Jan 27, 2023
S-furi
added a commit
to S-furi/Alchemist
that referenced
this pull request
Sep 8, 2023
This change is necessary for integrating the alchemist-graphql module, due to the strict JVM requirement that GraphQL Kotlin needs (JVM >= 17). See ExpediaGroup/graphql-kotlin#1638 on why GraphQL Kotlin needs such JVM version (TL;DR this library is mainly built for SpringBoot applications, and SpringBoot v3 requires JVM 17).
S-furi
added a commit
to S-furi/Alchemist
that referenced
this pull request
Sep 12, 2023
This change is necessary for integrating the alchemist-graphql module, due to the strict JVM requirement that GraphQL Kotlin needs (JVM >= 17). See ExpediaGroup/graphql-kotlin#1638 on why GraphQL Kotlin needs such JVM version (TL;DR this library is mainly built for SpringBoot applications, and SpringBoot v3 requires JVM 17).
S-furi
added a commit
to S-furi/Alchemist
that referenced
this pull request
Sep 12, 2023
This change is necessary for integrating the alchemist-graphql module, due to the strict JVM requirement that GraphQL Kotlin needs (JVM >= 17). See ExpediaGroup/graphql-kotlin#1638 on why GraphQL Kotlin needs such JVM version (TL;DR this library is mainly built for SpringBoot applications, and SpringBoot v3 requires JVM 17).
S-furi
added a commit
to S-furi/Alchemist
that referenced
this pull request
Sep 13, 2023
This change is necessary for integrating the alchemist-graphql module, due to the strict JVM requirement that GraphQL Kotlin needs (JVM >= 17). See ExpediaGroup/graphql-kotlin#1638 on why GraphQL Kotlin needs such JVM version (TL;DR this library is mainly built for SpringBoot applications, and SpringBoot v3 requires JVM 17).
S-furi
added a commit
to S-furi/Alchemist
that referenced
this pull request
Sep 14, 2023
This change is necessary for integrating the alchemist-graphql module, due to the strict JVM requirement that GraphQL Kotlin needs (JVM >= 17). See ExpediaGroup/graphql-kotlin#1638 on why GraphQL Kotlin needs such JVM version (TL;DR this library is mainly built for SpringBoot applications, and SpringBoot v3 requires JVM 17).
S-furi
added a commit
to S-furi/Alchemist
that referenced
this pull request
Sep 15, 2023
This change is necessary for integrating the alchemist-graphql module, due to the strict JVM requirement that GraphQL Kotlin needs (JVM >= 17). See ExpediaGroup/graphql-kotlin#1638 on why GraphQL Kotlin needs such JVM version (TL;DR this library is mainly built for SpringBoot applications, and SpringBoot v3 requires JVM 17).
DanySK
pushed a commit
to S-furi/Alchemist
that referenced
this pull request
Sep 15, 2023
This change is necessary for integrating the alchemist-graphql module, due to the strict JVM requirement that GraphQL Kotlin needs (JVM >= 17). See ExpediaGroup/graphql-kotlin#1638 on why GraphQL Kotlin needs such JVM version (TL;DR this library is mainly built for SpringBoot applications, and SpringBoot v3 requires JVM 17).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
SpringBoot v3 requires Java 17. This PR updates target bytecode of ALL
graphql-kotlinmodules to Java 17 and as a result ibrary users will have to use Java 17+ as well.🔗 Related Issues