Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add and use graphiql as default for browser IDE #1623

Merged
merged 5 commits into from
Dec 22, 2022

Conversation

samuelAndalon
Copy link
Contributor

@samuelAndalon samuelAndalon commented Dec 22, 2022

📝 Description

Prisma Labs Playground is deprecated and we should use the official GraphQL IDE under GraphQL foundation

GraphiQL will now be the default IDE under the /graphiql endpoint, while Playground will still be available with explicit opt-in through configuration properties

graphql:
  graphiql:
    enabled: true
  playground:
    enabled: false

🔗 Related Issues

#1589

Verified

This commit was signed with the committer’s verified signature.
sandhose Quentin Gliech
@samuelAndalon samuelAndalon added type: enhancement New feature or request changes: major Changes require a major version module: server Issue affects the server code labels Dec 22, 2022
@@ -0,0 +1,70 @@
<!--
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified

This commit was signed with the committer’s verified signature.
sandhose Quentin Gliech
@dariuszkuc
Copy link
Collaborator

Instead of

graphql:
  browserIDE:
    ide: "PLAYGROUND"

I think it might be simpler to keep those configs separate:

  • easier to drop support for tooling in future
  • easier to add additional tooling (if ever needed)
  • ability to use multiple tools
graphql:
  playground:
    enabled: true
    endpoint: "graphiql"
  playground:
    enabled: false
    endpoint: "playground"
  # altair|studio|voyager|etc

Verified

This commit was signed with the committer’s verified signature.
sandhose Quentin Gliech

Verified

This commit was signed with the committer’s verified signature.
sandhose Quentin Gliech

Verified

This commit was signed with the committer’s verified signature.
sandhose Quentin Gliech
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes: major Changes require a major version module: server Issue affects the server code type: enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

None yet

2 participants