Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[federation] update federation example and enable tests #1599

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

dariuszkuc
Copy link
Collaborator

@dariuszkuc dariuszkuc commented Nov 8, 2022

📝 Description

Update Apollo Federation example to match Federation JVM Spring Example schemas. DGS and GraphQL Java Kickstart also implement the same example schemas.

Changes:

  • Updated base-app/extend-app to match products-subgraph/reviews-subgraph schemas
  • Added integration tests to both subgraph (start app and run query)
  • Updated to use new Rust Router.
  • Added CI that builds the composition, starts the supergraph and runs federated query

🔗 Related Issues

Resolves #390
Would prevent #1595

@dariuszkuc dariuszkuc added status: do not merge Do not merge until this is removed type: tool update CI, code coverage, or linter updates module: examples Changes to the examples which are not part of the published library labels Nov 8, 2022
@dariuszkuc
Copy link
Collaborator Author

Should be merged after #1598

@dariuszkuc
Copy link
Collaborator Author

Example composition test results -> https://github.com/dariuszkuc/graphql-kotlin/actions/runs/3423004460

Update Apollo Federation example to match [Federation JVM Spring Example](https://github.com/apollographql/federation-jvm-spring-example) schemas. DGS and GraphQL Java Kickstart also implement the same example schemas.

Changes:

* Updated base-app/extend-app to match products-subgraph/reviews-subgraph schemas
* Added integration tests to both subgraph (start app and run query)
* Updated to use new [Rust Router](https://www.apollographql.com/docs/router/).
* Added CI that builds the composition, starts the supergraph and runs federated query

Related:

Resolves ExpediaGroup#390
@dariuszkuc dariuszkuc removed the status: do not merge Do not merge until this is removed label Nov 9, 2022
@samuelAndalon samuelAndalon merged commit 533dc03 into ExpediaGroup:master Nov 10, 2022
@dariuszkuc dariuszkuc deleted the fed_tests branch November 12, 2022 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: examples Changes to the examples which are not part of the published library type: tool update CI, code coverage, or linter updates
Development

Successfully merging this pull request may close these issues.

create integration tests for example federation
2 participants