[federation] cleanup validation rules #1581
Merged
+1,230
−1,586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies for the large PR -> its mostly due to the complete rewrite of the integration tests. Actual code is just in the |
dariuszkuc
added
changes: patch
Cleanup field set validation rules based on Federation v2 functionality. Validator now verifies: - @key, @provides and @requires field sets reference existing fields - @requires references @external fields - @provides references an object - field sets cannot reference unions - list and interfaces can only be referenced from `@requires` and `@provides`
samuelAndalon
approved these changes
Oct 29, 2022
dariuszkuc
added a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Nov 4, 2022
`@extends` is no longer needed in Fed 2. Missed this in previous validation rule cleanup (ExpediaGroup#1581).
dariuszkuc
added a commit
that referenced
this pull request
Nov 6, 2022
`@extends` is no longer needed in Fed 2. Missed this in previous validation rule cleanup (#1581).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Cleanup field set validation rules based on Federation v2 functionality.
Validator now verifies:
@requiresand@provides🔗 Related Issues