[client] update Jackson client to always annotate input fields #1579
+121
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Jackson client generation logic to always annotate input fields with `@get:JsonProperty`. This is a workaround to Jackson limitations due to its reliance on reflections to find getters/setters following JavaBean naming conventions.
Given a simple data class:
```kotlin
data class Foo(
val isBoolean: Boolean = true,
val isNotBoolean: String = "yes",
val NOT: Boolean = true,
val pID: Int = 1
)
```
It would be serialized as (before this change):
```json
{
"isBoolean" : true,
"not" : true,
"pid" : 1
}
```
After this change:
```json
{
"isBoolean" : true,
"isNotBoolean" : "yes",
"NOT" : true,
"pID" : 1
}
```
---
Resolves:
* ExpediaGroup#1486
* ExpediaGroup#1569
* ExpediaGroup#1578
dariuszkuc
added
changes: minor
samuelAndalon
approved these changes
Oct 19, 2022
|
@dariuszkuc thanks for tackling this so quickly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Update Jackson client generation logic to always annotate input fields with
@get:JsonProperty. This is a workaround to Jackson limitations due to its reliance on reflections to find getters/setters following JavaBean naming conventions.Given a simple data class:
It would be serialized as (before this change):
{ "isBoolean" : true, "not" : true, "pid" : 1 }After this change:
{ "isBoolean" : true, "isNotBoolean" : "yes", "NOT" : true, "pID" : 1 }🔗 Related Issues
GraphQLClientJacksonSerializersilently skips someis-prefixed input fields #1578