Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: graphQL errors per federated type element in batch #1568

Merged
merged 2 commits into from
Oct 12, 2022
Merged

feat: graphQL errors per federated type element in batch #1568

merged 2 commits into from
Oct 12, 2022
+77 −48

Conversation

samuelAndalon
Copy link
Contributor

@samuelAndalon samuelAndalon commented Oct 3, 2022 •
edited
Loading

📝 Description

Allowing each element in a _entities query batch to fail (by throwing an exception) without breaking the execution of the other representations

🔗 Related Issues

#1563

@samuelAndalon samuelAndalon added changes: minor Changes require a minor version module: generator Issue affects the schema generator and federation code labels Oct 3, 2022
@samuelAndalon samuelAndalon mentioned this pull request Oct 3, 2022
Closed
@samuelAndalon samuelAndalon merged commit b2148ca into ExpediaGroup:master Oct 12, 2022
@samuelAndalon samuelAndalon deleted the feat/error-per-federated-type branch October 12, 2022 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariuszkuc dariuszkuc

@Samjin Samjin

@tapaderster tapaderster

Assignees
No one assigned
Labels
changes: minor Changes require a minor version module: generator Issue affects the schema generator and federation code
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samuelAndalon @dariuszkuc