Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[federation] rename _FieldSet to FieldSet in Federation v2 #1547

Merged
merged 2 commits into from
Sep 13, 2022

Conversation

dariuszkuc
Copy link
Collaborator

📝 Description

Per Apollo Specification, _FieldSet was renamed to FieldSet in Federation v2.

🔗 Related Issues

Resolves: #1512

Per [Apollo Specification](https://www.apollographql.com/docs/federation/federation-spec), `_FieldSet` was renamed to `FieldSet` in Federation v2.

Resolves: ExpediaGroup#1512
@dariuszkuc dariuszkuc added changes: patch Changes require a patch version module: generator Issue affects the schema generator and federation code labels Sep 12, 2022
@samuelAndalon samuelAndalon merged commit 7010f6f into ExpediaGroup:master Sep 13, 2022
@dariuszkuc dariuszkuc deleted the fieldset branch September 16, 2022 02:47
samuelAndalon pushed a commit that referenced this pull request Dec 16, 2022
…1618)

* [federation] rename _FieldSet to FieldSet in Federation v2

Per [Apollo Specification](https://www.apollographql.com/docs/federation/federation-spec), `_FieldSet` was renamed to `FieldSet` in Federation v2.

Resolves: #1512

* ktlint - unused imports

Co-authored-by: Dariusz Kuc <9501705+dariuszkuc@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes: patch Changes require a patch version module: generator Issue affects the schema generator and federation code
Development

Successfully merging this pull request may close these issues.

Incorrect name for FieldSet scalar in Federation v2
2 participants