Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input-time-zone emits multiple open/close events when toggling open #9315

Open
2 of 6 tasks
nwhittaker opened this issue May 10, 2024 · 0 comments
Open
2 of 6 tasks
Labels
0 - new New issues that need assignment. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone needs triage Planning workflow - pending design/dev review.

Comments

@nwhittaker
Copy link
Contributor

nwhittaker commented May 10, 2024

Check existing issues

Actual Behavior

When enabling the input-time-zone component's open prop, events are emitted in this order:

  1. calciteInputTimeZoneOpen
  2. calciteInputTimeZoneBeforeOpen
  3. calciteInputTimeZoneOpen

When disabling the input-time-zone component's open prop, events are emitted in this order:

  1. calciteInputTimeZoneClose
  2. calciteInputTimeZoneBeforeClose
  3. calciteInputTimeZoneClose

Expected Behavior

Presumably the first calciteInputTimeZoneOpen and calciteInputTimeZoneClose events never occur.

Reproduction Sample

https://codepen.io/nwhittaker-esri/pen/BaeaXom

Reproduction Steps

  1. Visit the sample and open the console
  2. Click the Toggle time zone input a few times and see the order of emitted events appear in the console

Reproduction Version

2.8.0

Relevant Info

Encountered while investigating a workaround for the issue where opened overlays do not dismiss when clicking outside of them but on an element that stops event propagation.

Regression?

No response

Priority impact

p3 - want for upcoming milestone

Impact

Impact is minimal since we don't currently make use of these input-time-zone events.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Field Apps

@nwhittaker nwhittaker added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels May 10, 2024
@github-actions github-actions bot added p3 - want for upcoming milestone calcite-components Issues specific to the @esri/calcite-components package. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. labels May 10, 2024
@geospatialem geospatialem added impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone and removed p3 - want for upcoming milestone labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone needs triage Planning workflow - pending design/dev review.
Projects
None yet
Development

No branches or pull requests

2 participants