Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notice] improve text end padding #9287

Open
1 of 6 tasks
SkyeSeitz opened this issue May 8, 2024 · 1 comment
Open
1 of 6 tasks

[Notice] improve text end padding #9287

SkyeSeitz opened this issue May 8, 2024 · 1 comment
Labels
0 - new New issues that need assignment. Calcite (design) Issues logged by Calcite designers. enhancement Issues tied to a new feature or request. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. needs triage Planning workflow - pending design/dev review. ready for dev Issues ready for development implementation.

Comments

@SkyeSeitz
Copy link

SkyeSeitz commented May 8, 2024

Check existing issues

Description

On medium scale, when the icon prop is populated, there is 16px of block end padding on the text container, which changes to 12px when the icon prop is not populated. On large scale, this is 20px & 16px. On small scale, this is 10px & 8px
image

Acceptance Criteria

  1. Remove conditional block end padding that changes the 12px to 16px on medium, 16px 20px on large, and 8px to 10px on small when the icon prop is populated.
image
  1. Add conditional padding to change the 12px to 16px on medium, 16px 20px on large, and 8px to 10px on small when no slot or prop is populated at the end of the text container, allowing the start and end padding to be visually balanced.
image

Relevant Info

cc @ashetland @adam

Which Component

Notice

Example Use Case

No response

Priority impact

p4 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)

@SkyeSeitz SkyeSeitz added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. ready for dev Issues ready for development implementation. labels May 8, 2024
@github-actions github-actions bot added impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive Calcite (design) Issues logged by Calcite designers. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels May 8, 2024
Copy link
Contributor

github-actions bot commented May 8, 2024

cc @geospatialem, @brittneytewks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. Calcite (design) Issues logged by Calcite designers. enhancement Issues tied to a new feature or request. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. needs triage Planning workflow - pending design/dev review. ready for dev Issues ready for development implementation.
Projects
None yet
Development

No branches or pull requests

1 participant