Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple tiles with the selected attribute display as selected in both single and single-persist groups #9271

Closed
2 of 6 tasks
eriklharper opened this issue May 6, 2024 · 2 comments
Closed
2 of 6 tasks

Multiple tiles with the selected attribute display as selected in both single and single-persist groups #9271

eriklharper opened this issue May 6, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2024-05-28 - May ...

Comments

@eriklharper
Copy link
Contributor

Check existing issues

Actual Behavior

Including the selected attribute on more than 1 calcite-tile element inside calcite-tile-group with either single or single-persist selection modes appear selected when only the last one should be.

Expected Behavior

According to the HTML spec for radio buttons, the last selected element in DOM order should be the selected element.

image

Reproduction Sample

https://codepen.io/eriklharper/pen/NWmQZoL?editors=1010

Reproduction Steps

  1. Open the Codepen Reproduction Sample
  2. Observe that all Tiles that include a selected attribute appear selected.

Reproduction Version

2.8.0

Relevant Info

No response

Regression?

No response

Priority impact

p3 - want for upcoming milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (dev)
@eriklharper eriklharper added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels May 6, 2024
@eriklharper eriklharper changed the title Multiple Tiles with the selected attribute display as selected in both single and single-persist groups Multiple tiles with the selected attribute display as selected in both single and single-persist groups May 6, 2024
@github-actions github-actions bot added Calcite (dev) Issues logged by Calcite developers. p3 - want for upcoming milestone calcite-components Issues specific to the @esri/calcite-components package. labels May 6, 2024
@eriklharper eriklharper mentioned this issue May 6, 2024
Open
5 tasks
@josercarcamo josercarcamo self-assigned this May 7, 2024
@josercarcamo josercarcamo added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels May 8, 2024
@josercarcamo josercarcamo mentioned this issue May 8, 2024
Merged
josercarcamo added a commit that referenced this issue May 9, 2024
@josercarcamo
fix(tile-group): disallow multiple selected attributes on single sele…
885909e 
…ction modes (#9284)

**Related Issue:** #9271 

## Summary
Displayed only the last tile as selected when multiple tiles have the selected attribute.
@josercarcamo josercarcamo added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels May 9, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned josercarcamo May 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2024

Installed and assigned for verification.

@jcfranco jcfranco added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. and removed needs triage Planning workflow - pending design/dev review. labels May 9, 2024
@DitwanP
Copy link
Contributor

DitwanP commented May 13, 2024

🍡 Verified on 2.9.0-next.4

@DitwanP DitwanP closed this as completed May 13, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2024-05-28 - May Main Release
Development

No branches or pull requests
5 participants
@jcfranco @eriklharper @geospatialem @DitwanP @josercarcamo