#834 Support skipping input chunks after a buffer underflow #850
+22
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theigl
force-pushed
the
834-skip-chunk-after-underflow
branch
from
b093eca to
fd6e657
Compare
theigl
added a commit
that referenced
this pull request
May 19, 2023
yaooqinn
pushed a commit
to apache/spark
that referenced
this pull request
Apr 16, 2025
### What changes were proposed in this pull request? This pr aims to upgrade `kryo-shaded` from 4.0.2 to 4.0.3. ### Why are the changes needed? This version brings some bug fixes and performance improvements related to chunked encoding: - mproved filling InputChunked buffer: EsotericSoftware/kryo#651 - Support skipping input chunks after a buffer underflow EsotericSoftware/kryo#850 - Avoid flush repeatedly when has finished flushing EsotericSoftware/kryo#978 full changes as follows: - EsotericSoftware/kryo@kryo-parent-4.0.2...kryo-parent-4.0.3 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? - Pass GitHub Actions ### Was this patch authored or co-authored using generative AI tooling? No Closes #50586 from LuciferYang/kryo-4.0.3. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Kent Yao <yao@apache.org>
LuciferYang
added a commit
to apache/spark
that referenced
this pull request
Apr 17, 2025
### What changes were proposed in this pull request? This pr aims to upgrade `kryo-shaded` from 4.0.2 to 4.0.3. ### Why are the changes needed? This version brings some bug fixes and performance improvements related to chunked encoding: - mproved filling InputChunked buffer: EsotericSoftware/kryo#651 - Support skipping input chunks after a buffer underflow EsotericSoftware/kryo#850 - Avoid flush repeatedly when has finished flushing EsotericSoftware/kryo#978 full changes as follows: - EsotericSoftware/kryo@kryo-parent-4.0.2...kryo-parent-4.0.3 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? - Pass GitHub Actions ### Was this patch authored or co-authored using generative AI tooling? No Closes #50603 from LuciferYang/SPARK-51806-4.0. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: yangjie01 <yangjie01@baidu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buffer underflows set the buffer position to 0 while trying to resize the buffer. This prevents
InputChunked.nextChunk()from advancing to the next chunk.This PR ensures that that the buffer is at the final position of the chunk before advancing to the next chunk.
Resolves #834.