Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all references to Pokemon for template to be useful #502

Open
AleksandarDev opened this issue Oct 25, 2023 · 1 comment
Open

Remove all references to Pokemon for template to be useful #502

AleksandarDev opened this issue Oct 25, 2023 · 1 comment

Comments

@AleksandarDev
Copy link
Member

AleksandarDev commented Oct 25, 2023

Statement: template currently requires too much editing and cleaning before it can be used in new project.

Proposed changes:

  1. remove all pokemon related stuff and replace with something every app requires
  2. replace all pokemon related examples and explanations in Readme
  3. remove all "Enterwell was previsously ... and now we ..." paragraphs from Readme - this is not a migration guide
@radovix
Copy link
Member

radovix commented Jan 26, 2024

I kind of disagree on this one. As README pretty clearly states, Pokemon example is here so that we can demonstrate the use of starter and architecture. Although it really takes some time to remove all Pokemon references, that is done once per project. What I suggest that we can do is add a script for removing Pokemon related stuff or we can remove Pokemon related code, but move the current state of the starter to examples project. Pokemon related examples shouldn't be removed from the README in my opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants