Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deferred configuration never resolves in manual mode #102

Closed
EmmanuelRoux opened this issue Jan 3, 2025 · 2 comments
Closed

Deferred configuration never resolves in manual mode #102

EmmanuelRoux opened this issue Jan 3, 2025 · 2 comments
Assignees
Labels
bug Something isn't working released

Comments

@EmmanuelRoux
Copy link
Owner

When using manual initialization mode, some errors may occur when waiting for deferred configuration, because deferred configuration is never resolved.

It should be resolved to an empty trackers configuration instead.

@EmmanuelRoux EmmanuelRoux added the bug Something isn't working label Jan 3, 2025
@EmmanuelRoux EmmanuelRoux self-assigned this Jan 3, 2025
EmmanuelRoux added a commit that referenced this issue Jan 3, 2025
# [6.4.0](v6.3.1...v6.4.0) (2025-01-03)

### Bug Fixes

* correctly resolve deferred configuration when using `manual` initialization mode ([da82506](da82506)), closes [#102](#102)

### Features

* add `getCustomData` and `setCustomData` tracker API methods ([e76564c](e76564c))
* add optional _custom data_ parameter to event tracking ([0cdda40](0cdda40))
* add optional _custom data_ parameter to goal tracking ([6e21b91](6e21b91))
* add optional _custom data_ parameter to link tracking ([cfb42b1](cfb42b1))
* add optional _custom data_ parameter to site search tracking ([fa35f1c](fa35f1c)), closes [#96](#96)
* allow providing Matomo in lazy-loaded components/modules ([#98](#98)) ([45a5a0e](45a5a0e))
@EmmanuelRoux
Copy link
Owner Author

🎉 This issue has been resolved in version 6.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

EmmanuelRoux added a commit that referenced this issue Jan 14, 2025
…tialization mode

fixes #102

(cherry picked from commit da82506)
EmmanuelRoux added a commit that referenced this issue Jan 14, 2025
# [7.0.0](v6.4.1...v7.0.0) (2025-01-14)

### Bug Fixes

* correctly inject legacy `MatomoRouterModule` and `NgxMatomoRouterModule` ([c2f7fda](c2f7fda)), closes [#105](#105) [#104](#104)
* correctly resolve deferred configuration when using `manual` initialization mode ([f0bb6c1](f0bb6c1)), closes [#102](#102)
* prepare testing api update ([0471e41](0471e41))

### Features

* add compatibility with Angular 19 (#101) ([bfae2b7](bfae2b7)), closes [#99](#99) [#103](#103)
* add new `withPageUrlProvider` feature and allow functional-style provider ([3d002d8](3d002d8))
* allow providing Matomo in lazy-loaded components/modules (#98) ([2982fc4](2982fc4)), closes [#97](#97)
* allow providing page url as promise ([5bb76a4](5bb76a4))

### Breaking changes

* Angular v19 is now required as peer dependency
* Some of your tests may be broken, you may need to provide Matomo in `TestBed` using `provideMatomoTesting()`.

### Deprecations

* `MatomoTestingTracker.setMatomoInstance` has been deprecated, provide a `MATOMO_TESTING_INSTANCE` DI token instead
@EmmanuelRoux
Copy link
Owner Author

🎉 This issue has been resolved in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

No branches or pull requests

1 participant