Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unicode-ident no longer getting its Unicode License Agreement from the crate [regression from 0.6.2] #267

Closed
jrose-signal opened this issue Nov 18, 2024 · 1 comment · Fixed by #268
Labels
bug Something isn't working

Comments

@jrose-signal
Copy link

With cargo-about 0.6.2, a crate depending on unicode-ident 1.0.13 would (correctly) get two licenses listed, per its license of (MIT OR Apache-2.0) AND Unicode-DFS-2016. Both of these were pulled from the source files of the crate. With cargo-about 0.6.5, both licenses still appear, but the Unicode license is now "synthesized".

I don't have a standalone repro, but I doubt it's anything strange we're doing; still, here are the steps for us:

  1. Check out https://github.com/signalapp/libsignal/releases/tag/v0.62.0, whose acknowledgments were generated by cargo-about 0.6.2.
  2. Install cargo-about 0.6.5
  3. Change acknowledgments/cargo-about-version to 0.6.5
  4. Run bin/regenerate-acknowledgments.sh
  5. Observe the diff in acknowledgments/acknowledgments.html

(Note that the license file for ryu is also newly marked synthesized, but is not actually synthesized; this is because the crate really does contain a license template without the name filled in. I'm not sure why this behavior would have changed between 0.6.2 and 0.6.5, though, so maybe it's related. half has a similar problem even in 0.6.2.)

@jrose-signal jrose-signal added the bug Something isn't working label Nov 18, 2024
@Jake-Shadle
Copy link
Member

The issue seems to be that the license text differs significantly enough from the canonical text that it actually ends up being a closer match to Unicode-3.0, and since that license isn't used by the crate it falls back to the canonical text the crate says it is licensed under.

As far as why the behavior differs, I forgot to update the spdx cache used by askalono, so it was using the 3.18.0 license list data, which didn't have the Unicode-3.0 license at all, so the Unicode-DFS-2016 text would be the closest match.

I'll add a workaround since this crate is used everywhere, but open a PR to use the actual correct text.

Jake-Shadle added a commit to Jake-Shadle/unicode-ident that referenced this issue Nov 19, 2024
I'm unsure where the LICENSE-UNICODE text in this repo originated, but it's fairly different from the [canonical text](https://spdx.org/licenses/Unicode-DFS-2016.html) in the SPDX license list, so this updates it to match.

The reason for this change is that the Unicode-3.0 license was added recently, which can actually be a [closer match](EmbarkStudios/cargo-about#267) to the current text, resulting in the SPDX identifier mismatching the actual one this crate is licensed under.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants