You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With cargo-about 0.6.2, a crate depending on unicode-ident 1.0.13 would (correctly) get two licenses listed, per its license of (MIT OR Apache-2.0) AND Unicode-DFS-2016. Both of these were pulled from the source files of the crate. With cargo-about 0.6.5, both licenses still appear, but the Unicode license is now "synthesized".
I don't have a standalone repro, but I doubt it's anything strange we're doing; still, here are the steps for us:
Change acknowledgments/cargo-about-version to 0.6.5
Run bin/regenerate-acknowledgments.sh
Observe the diff in acknowledgments/acknowledgments.html
(Note that the license file for ryu is also newly marked synthesized, but is not actually synthesized; this is because the crate really does contain a license template without the name filled in. I'm not sure why this behavior would have changed between 0.6.2 and 0.6.5, though, so maybe it's related. half has a similar problem even in 0.6.2.)
The text was updated successfully, but these errors were encountered:
The issue seems to be that the license text differs significantly enough from the canonical text that it actually ends up being a closer match to Unicode-3.0, and since that license isn't used by the crate it falls back to the canonical text the crate says it is licensed under.
As far as why the behavior differs, I forgot to update the spdx cache used by askalono, so it was using the 3.18.0 license list data, which didn't have the Unicode-3.0 license at all, so the Unicode-DFS-2016 text would be the closest match.
I'll add a workaround since this crate is used everywhere, but open a PR to use the actual correct text.
I'm unsure where the LICENSE-UNICODE text in this repo originated, but it's fairly different from the [canonical text](https://spdx.org/licenses/Unicode-DFS-2016.html) in the SPDX license list, so this updates it to match.
The reason for this change is that the Unicode-3.0 license was added recently, which can actually be a [closer match](EmbarkStudios/cargo-about#267) to the current text, resulting in the SPDX identifier mismatching the actual one this crate is licensed under.
With cargo-about 0.6.2, a crate depending on unicode-ident 1.0.13 would (correctly) get two licenses listed, per its license of
(MIT OR Apache-2.0) AND Unicode-DFS-2016
. Both of these were pulled from the source files of the crate. With cargo-about 0.6.5, both licenses still appear, but the Unicode license is now "synthesized".I don't have a standalone repro, but I doubt it's anything strange we're doing; still, here are the steps for us:
(Note that the license file for
ryu
is also newly marked synthesized, but is not actually synthesized; this is because the crate really does contain a license template without the name filled in. I'm not sure why this behavior would have changed between 0.6.2 and 0.6.5, though, so maybe it's related.half
has a similar problem even in 0.6.2.)The text was updated successfully, but these errors were encountered: