ReadonlyArray: fix sort signature, closes #2301 (#2303)

Author: gcanti

.changeset/swift-pugs-train.md

@@ -0,0 +1,5 @@
+---
+"effect": patch
+---
+
+ReadonlyArray: fix `sort` signature, closes #2301

packages/effect/dtslint/ReadonlyArray.ts

@@ -2,7 +2,7 @@ import * as Effect from "effect/Effect"
 import * as Equal from "effect/Equal"
 import { hole, identity, pipe } from "effect/Function"
 import * as Option from "effect/Option"
-import type * as Order from "effect/Order"
+import * as Order from "effect/Order"
 import * as Predicate from "effect/Predicate"
 import * as ReadonlyArray from "effect/ReadonlyArray"
 
@@ -216,6 +216,15 @@ pipe(nonEmptyabs, ReadonlyArray.sort(ordera))
 // $ExpectType [AB, ...AB[]]
 ReadonlyArray.sort(ordera)(nonEmptyabs)
 
+// @ts-expect-error
+pipe([1], ReadonlyArray.sort(Order.string))
+
+// @ts-expect-error
+ReadonlyArray.sort([1], Order.string)
+
+// @ts-expect-error
+ReadonlyArray.sort(Order.string)([1])
+
 // -------------------------------------------------------------------------------------
 // sortWith
 // -------------------------------------------------------------------------------------

packages/effect/src/ReadonlyArray.ts

@@ -883,7 +883,7 @@ export const reverse = <S extends Iterable<any> | NonEmptyReadonlyArray<any>>(
 export const sort: {
   <B>(
     O: Order.Order<B>
-  ): <S extends ReadonlyArray<any> | Iterable<any>>(self: S) => ReadonlyArray.With<S, ReadonlyArray.Infer<S>>
+  ): <A extends B, S extends ReadonlyArray<A> | Iterable<A>>(self: S) => ReadonlyArray.With<S, ReadonlyArray.Infer<S>>
   <A extends B, B>(self: NonEmptyReadonlyArray<A>, O: Order.Order<B>): NonEmptyArray<A>
   <A extends B, B>(self: Iterable<A>, O: Order.Order<B>): Array<A>
 } = dual(2, <A extends B, B>(self: Iterable<A>, O: Order.Order<B>): Array<A> => {