Skip to content

Commit 6654f5f

Browse files
authoredFeb 10, 2024
default to never for Runtime returning functions (#2096)
1 parent 2eb11b4 commit 6654f5f

File tree

3 files changed

+15
-2
lines changed

3 files changed

+15
-2
lines changed
 

‎.changeset/brave-rats-travel.md

+13
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
---
2+
"effect": patch
3+
---
4+
5+
default to `never` for Runtime returning functions
6+
7+
This includes:
8+
9+
- Effect.runtime
10+
- FiberSet.makeRuntime
11+
12+
It prevents `unknown` from creeping into types, as well as `never` being a
13+
useful default type for propogating Fiber Refs and other context.

‎packages/effect/src/Effect.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -4536,7 +4536,7 @@ export const randomWith: <A, E, R>(f: (random: Random.Random) => Effect<A, E, R>
45364536
* @since 2.0.0
45374537
* @category runtime
45384538
*/
4539-
export const runtime: <R>() => Effect<Runtime.Runtime<R>, never, R> = _runtime.runtime
4539+
export const runtime: <R = never>() => Effect<Runtime.Runtime<R>, never, R> = _runtime.runtime
45404540

45414541
/**
45424542
* Retrieves an effect that succeeds with the current runtime flags, which

‎packages/effect/src/FiberSet.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ export const make = <A = unknown, E = unknown>(): Effect.Effect<FiberSet<A, E>,
101101
* @since 2.0.0
102102
* @categories constructors
103103
*/
104-
export const makeRuntime = <R, A = unknown, E = unknown>(): Effect.Effect<
104+
export const makeRuntime = <R = never, A = unknown, E = unknown>(): Effect.Effect<
105105
<XE extends E, XA extends A>(
106106
effect: Effect.Effect<XA, XE, R>,
107107
options?: Runtime.RunForkOptions | undefined

0 commit comments

Comments
 (0)
Please sign in to comment.