Skip to content

Commit fdbf0f9

Browse files
committedNov 26, 2024·
bug #6573 Replace sr-only class with visually-hidden (JorickPepin)
This PR was merged into the 4.x branch. Discussion ---------- Replace `sr-only` class with `visually-hidden` Ref https://getbootstrap.com/docs/5.2/getting-started/accessibility/#visually-hidden-content I've noticed since version 4.16.0 that fields with `sr-only` class have become visible. This seems to be because the `sr-only` class is no longer available in Bootstrap, but was still present in the recently removed font-awesome assets. E.g. the actions `<th>`: ![image](https://github.com/user-attachments/assets/0ca21e0c-0817-4d7c-aa6c-a8561eb56261) Commits ------- fc0b958 Replace `sr-only` class with `visually-hidden`
2 parents bb47199 + fc0b958 commit fdbf0f9

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed
 

‎templates/crud/index.html.twig

+1-1
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@
128128
{% endfor %}
129129

130130
<th class="{{ ea.crud.showEntityActionsAsDropdown ? 'actions-as-dropdown-table-head' }}" dir="{{ ea.i18n.textDirection }}">
131-
<span class="sr-only">{{ t('action.entity_actions', ea.i18n.translationParameters, 'EasyAdminBundle')|trans }}</span>
131+
<span class="visually-hidden">{{ t('action.entity_actions', ea.i18n.translationParameters, 'EasyAdminBundle')|trans }}</span>
132132
</th>
133133
</tr>
134134
{% endblock table_head %}

0 commit comments

Comments
 (0)
Please sign in to comment.