bug #6678 Fix some issues with menu item badges that have no value (javiereguiluz)

This PR was merged into the 4.x branch.

Discussion
----------

Fix some issues with menu item badges that have no value

Fixes #5847.

Commits
-------

afc9261 Fix some issues with menu item badges that have no value

Author: javiereguiluz

src/Dto/MenuItemDto.php

@@ -220,6 +220,18 @@ public function setBadge(mixed $content, string $style, array $htmlAttributes =
         $this->badge = new MenuItemBadgeDto($content, trim($style), $htmlAttributes);
     }
 
+    /**
+     * Tells if the badge HTML element should be displayed or not. This is used
+     * e.g. to not display a badge when its value is null or false.
+     */
+    public function hasVisibleBadge(): bool
+    {
+        $badgeContent = $this->getBadge()?->getContent();
+
+        // the number 0 is not included here because it's valid to display a badge with the value 0
+        return null !== $badgeContent && false !== $badgeContent && '' !== $badgeContent;
+    }
+
     /**
      * @return MenuItemDto[]
      */

templates/menu.html.twig

@@ -59,7 +59,7 @@
                 {{ item.label|trans|raw }}
             </span>
             {% if item.hasSubItems %}<twig:ea:Icon name="internal:chevron-right" class="submenu-toggle-icon" />{% endif %}
-            {% if item.badge %}
+            {% if item.hasVisibleBadge %}
                 <span class="menu-item-badge rounded-pill badge {{ item.badge.cssClass }}" {{ _self.render_html_attributes(item.badge) }} style="{{ item.badge.htmlStyle }}">{{ item.badge.content }}</span>
             {% endif %}
         </a>