Skip to content

Commit 92b3d9f

Browse files
committedNov 28, 2024·
feature #6600 Revert FontAwesome icons changes (javiereguiluz)
This PR was squashed before being merged into the 4.x branch. Discussion ---------- Revert FontAwesome icons changes This reverts #6537 partially to make FontAwesome icons behave as before. Fixes #6593, #6582, #6581. Commits ------- eb500fb Revert FontAwesome icons changes
2 parents 4e772c0 + eb500fb commit 92b3d9f

File tree

2,089 files changed

+214
-4008
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

2,089 files changed

+214
-4008
lines changed
 

‎UPGRADE.md

+14-22
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,18 @@
11
Upgrade between EasyAdmin 4.x versions
22
======================================
33

4+
EasyAdmin 4.18.0
5+
----------------
6+
7+
### Reverted FontAwesome Icon Changes
8+
9+
In EasyAdmin 4.16.0, we introduced a feature allowing the use of custom icon
10+
sets in addition to the default FontAwesome icons. As part of this update,
11+
FontAwesome icons were changed to be rendered as inline SVGs instead of being
12+
applied via CSS classes. **This change has been reverted in this version**,
13+
restoring the previous behavior so you can continue using FontAwesome icons as
14+
before in EasyAdmin.
15+
416
EasyAdmin 4.17.0
517
----------------
618

@@ -18,28 +30,8 @@ EasyAdmin 4.16.0
1830

1931
### FontAwesome Icons Are Now Inlined as SVGs
2032

21-
As part of the new feature that allows to use custom icon sets, the FontAwesome
22-
icons included by default in EasyAdmin are now inlined as SVGs. The font files
23-
(.ttf, .woff2) and the CSS file that loads the icons have been removed.
24-
25-
This doesn't require any change on your side, unless you were relying on the
26-
FontAwesome CSS classes to style the icons, which is something undocumented and
27-
not recommended. In that case, replace the `fa-*` CSS classes by the new Twig
28-
Component that renders icons:
29-
30-
```twig
31-
{# Before: #}
32-
<i class="fa-regular fa-user"></i>
33-
<i class="far fa-user"></i>
34-
<i class="fa-solid fa-tags"></i>
35-
<i class="fas fa-tags"></i>
36-
37-
{# After: #}
38-
<twig:ea:Icon name="fa6-regular:user" />
39-
<twig:ea:Icon name="fa6-regular:user" />
40-
<twig:ea:Icon name="fa6-solid:tags" />
41-
<twig:ea:Icon name="fa6-solid:tags" />
42-
```
33+
**REVERTED** This change was reverted in EasyAdmin 4.18.0. If you use FontAwesome
34+
icons, you don't have to do any change.
4335

4436
EasyAdmin 4.14.0
4537
----------------

‎assets/css/app.css

+4
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
11
@import "~bootstrap/dist/css/bootstrap.min.css";
22

3+
@import "~@fortawesome/fontawesome-free/css/all.css";
4+
@import "~@fortawesome/fontawesome-free/css/v4-shims.css";
5+
@import "~@fortawesome/fontawesome-free/css/v5-font-face.css";
6+
37
@import "./easyadmin-theme/theme.css";

0 commit comments

Comments
 (0)