bug #6814 Fix warning when matching menu item URLs without path (javiereguiluz)

javiereguiluz · javiereguiluz · commit 37fc36f33d30 · 2025-02-12T20:03:56.000+01:00
This PR was merged into the 4.x branch. Discussion ---------- Fix warning when matching menu item URLs without path Fixes #6813. Commits ------- d30df93 Fix warning when matching menu item URLs without path
diff --git a/src/Menu/MenuItemMatcher.php b/src/Menu/MenuItemMatcher.php
@@ -190,7 +190,7 @@ private function doMarkSelectedPrettyUrlsMenuItem(array $menuItems, Request $req
 
             // remove host part from the menu item link URL
             $urlParts = parse_url($menuItemDto->getLinkUrl());
-            $menuItemUrlWithoutHost = $urlParts['path'];
+            $menuItemUrlWithoutHost = $urlParts['path'] ?? '';
             if (\array_key_exists('query', $urlParts)) {
                 $menuItemUrlWithoutHost .= '?'.$urlParts['query'];
             }

Original file line number	Diff line number	Diff line change
`@@ -190,7 +190,7 @@ private function doMarkSelectedPrettyUrlsMenuItem(array $menuItems, Request $req`
`190`	`190`
`191`	`191`	`// remove host part from the menu item link URL`
`192`	`192`	`$urlParts = parse_url($menuItemDto->getLinkUrl());`
`193`		`- $menuItemUrlWithoutHost = $urlParts['path'];`
	`193`	`+ $menuItemUrlWithoutHost = $urlParts['path'] ?? '';`
`194`	`194`	`if (\array_key_exists('query', $urlParts)) {`
`195`	`195`	`$menuItemUrlWithoutHost .= '?'.$urlParts['query'];`
`196`	`196`	`}`