Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EF fixes #705

Merged
merged 4 commits into from
Feb 2, 2022
Merged

EF fixes #705

merged 4 commits into from
Feb 2, 2022

Conversation

brockallen
Copy link
Member

@brockallen brockallen commented Feb 1, 2022

This PR fixes two EF issues:

  • Client Store query has been reverted to the v5.x style, which makes multiple round trips to avoid the matrix multiplication when an inner join is used for the various child tables. Customers were experiencing worse performance with the inner join.

Fixes: #694

  • Quickstart Admin Pages for Client Creation: They were missing storing the client secret and the AllowOfflineAccess settings.

@brockallen brockallen added this to the 6.0.4 milestone Feb 1, 2022
@hugoqribeiro
Copy link

Have you tried AsSplitQuery? It works fine. I've confirmed that in our override of the client store.

@brockallen
Copy link
Member Author

Have you tried AsSplitQuery? It works fine. I've confirmed that in our override of the client store.

Doesn't that have the same effect as the way the code is written now?

@brockallen
Copy link
Member Author

Doesn't that have the same effect as the way the code is written now?

I just looked at the difference (at least on SqlServer). The AsSplitQuery doesn't reset the connection across the child tables queries, whereas the older approach does. I guess that'd end up being more efficient?

@brockallen brockallen merged commit 9dfb7e9 into releases/6.0.x Feb 2, 2022
@brockallen brockallen deleted the brock/v60x_patch_ef_client_store branch February 2, 2022 17:09
brockallen added a commit that referenced this pull request Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants