-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/cascader rendertrigger #2051
Conversation
…composition in keyEntities change
…composition in keyEntities change
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3c76bd5:
|
Passing run #2223 ↗︎
Details:
Review all test suite changes for PR #2051 ↗︎ |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2051 +/- ##
==========================================
+ Coverage 87.37% 87.42% +0.05%
==========================================
Files 437 437
Lines 25655 25664 +9
Branches 6501 6502 +1
==========================================
+ Hits 22417 22438 +21
+ Misses 3238 3226 -12 ☔ View full report in Codecov by Sentry. |
中文模板 / Chinese Template
What kind of change does this PR introduce? (check at least one)
PR description
Fixes # 本问题由于 #1999 的修改导致,为提高在大数据 treeData 的 Cascader 的性能,key 的生成规则发生改变。对于 如下 treeData
原来:和 TreeData 的中的位置有关,比如[浙江, 杭州, 西湖],key 为 0-0-0;
#1999 修改后: 将 value 用特殊字符连接,对于[浙江, 杭州, 西湖], key 为 zhejiang_SEMI_CASCADER_SPLIT_hangzhou
_SEMI_CASCADER_SPLIT_xihu;
修改后能够快速通过 key 找到 value,在受控时提升组件性能。
但是在根据原来 key 和 pos 关联的性质,原来的代码中有将 keyEntities中的 key 的值作为 triggerRender 中的 value 参数

,由于 key 的生成规则,变化,因此不再适合通过 keyEntities中的 key 的值作为 triggerRender 中的 value ,而是应该将真正的 pos 给到value。
因此本 PR 中的修改为:
Changelog
🇨🇳 Chinese
🇺🇸 English
Checklist
Other
Additional information