Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected SA1131 #3759

Closed
bjornhellander opened this issue Dec 20, 2023 · 5 comments · Fixed by #3760
Closed

Unexpected SA1131 #3759

bjornhellander opened this issue Dec 20, 2023 · 5 comments · Fixed by #3760
Labels
blocker bug fixed
Milestone
1.2.0-beta.556

Comments

@bjornhellander
Copy link
Contributor

I updated this repository to 1.2.0-beta.553 and got lots of unexpected SA1131.
Triggers for example on these cases:
x + 1 < y
a() < y

The common denominator seems to be that the left side or the operator is not just a variable, so this is probably a very common problem.
@bjornhellander
Copy link
Contributor Author

Investigating...

bjornhellander added a commit to bjornhellander/StyleCopAnalyzers that referenced this issue Dec 20, 2023
@bjornhellander
Fix SA1131 to not treat "complex" expressions as a literal
32646fb 
DotNetAnalyzers#3759
@sharwell
Copy link
Member

Likely caused by #3710

@bjornhellander
Copy link
Contributor Author

Indeed it is. Sorry.

I pushed a fix. If you feel the slightest bit unsure about this, you could revert dfd5ed2 instead.

@sharwell
Copy link
Member

Were you planning to submit a PR here?

@bjornhellander bjornhellander mentioned this issue Dec 20, 2023
Merged
@bjornhellander
Copy link
Contributor Author

Done now.

bjornhellander added a commit to bjornhellander/StyleCopAnalyzers that referenced this issue Dec 20, 2023
@bjornhellander
Fix review comments
e099358 
DotNetAnalyzers#3759
@sharwell sharwell added this to the 1.2-beta.next milestone Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocker bug fixed
Projects
None yet
Milestone
1.2.0-beta.556
Development

Successfully merging a pull request may close this issue.

Fix SA1131 to not treat "complex" expressions as a literal bjornhellander/StyleCopAnalyzers
2 participants
@sharwell @bjornhellander