You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am using pact-jvm-provider-junit_2.12,version 3.6.10 and I have a problem with verifying if defined rules by provider are valid.
Our application is having an XML request body and response and I am trying to verify if a specific field is having a value for an attribute.
The following rule:
has a synstax error due to the fact that description attribute is not enclosed with '', valid syntax would be ['@description']
In console there is a WARN about this: [main] WARN au.com.dius.pact.matchers.Matchers – Path expression $.serviceNode.entity.status.thirdNode['@description] is invalid, ignoring: [1.76] failure: '' expected but end of source found`
PACT framework is ingoring the rule due to invalid syntax and publish all interactions being passed in PACT broker.
Souldn't interactions that contains rules with invalid syntax to be marked as failed?
Because with the current behaviour is very hard to track each modification what we do in our pact file (we see all interactions had passed even tho there are some rules that were not executed due to invalid syntax)
Also if rule has invalid syntax would be more nice to have an ERROR logged instead of a WARN.
This might be related with changes performed in: #899
The text was updated successfully, but these errors were encountered:
vasile21
changed the title
Interactions that contains rules with invalid syntax are not marked as failed
XmlBodyMatcher - Interactions that contains rules with invalid syntax are not marked as failed
Oct 16, 2019
I am using pact-jvm-provider-junit_2.12,version 3.6.10 and I have a problem with verifying if defined rules by provider are valid.
Our application is having an XML request body and response and I am trying to verify if a specific field is having a value for an attribute.
The following rule:
has a synstax error due to the fact that description attribute is not enclosed with
''
, valid syntax would be ['@description']In console there is a WARN about this:
[main] WARN au.com.dius.pact.matchers.Matchers – Path expression $.serviceNode.entity.status.thirdNode['@description] is invalid, ignoring: [1.76] failure:
'' expected but end of source found`PACT framework is ingoring the rule due to invalid syntax and publish all interactions being passed in PACT broker.
Souldn't interactions that contains rules with invalid syntax to be marked as failed?
Because with the current behaviour is very hard to track each modification what we do in our pact file (we see all interactions had passed even tho there are some rules that were not executed due to invalid syntax)
Also if rule has invalid syntax would be more nice to have an
ERROR
logged instead of aWARN
.This might be related with changes performed in: #899
The text was updated successfully, but these errors were encountered: