Fix off-by-one valueFromProviderState index #1034
Merged
+24
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`PactDslJsonArray.valueFromProviderState()` assigns an index one less than it should. Before appending to the `body` array, the method invokes `appendArrayIndex`, which in turn emits an array index value of `body.length()-1`. Since the `body` array is yet to be updated the calculated index is off by one (the most obvious sign of this is a negative index of `-1`). This PR moves the append to `body` first.
kppullin
commented
Feb 28, 2020
| body.put(example); | ||
| generators.addGenerator(Category.BODY, rootPath + appendArrayIndex(0), new ProviderStateGenerator(expression)); |
There was a problem hiding this comment.
Another option here would be to change appendArrayIndex(0) to appendArrayIndex(1). I went the proposed approach instead as it matched most other patterns in the class and it didn't appear there was any dependencies on the order of operations here.
|
Thanks for the PR! I agree with your approach being the better option. |
|
Version 4.0.7 has been released with this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PactDslJsonArray.valueFromProviderState()assigns an indexone less than it should.
Before appending to the
bodyarray,the method invokes
appendArrayIndex(), which in turn emits anindex value of
body.length()-1. Since thebodyarray is yet tobe updated the calculated index is off by one (the most obvious
sign of this is a negative index of
-1).This PR moves the append to
bodyfirst.