Defer Runner initialization until it is run #1021
Merged
+38
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tools (e.g. Maven Surefire plugin) instantiate all potential Runners before filtering them (based on e.g. JUnit @category annotations). For Spring Runners, this means that an ApplicationContext will be created, even if the tests are subsequently skipped, increasing build times.
aplsup
approved these changes
Feb 17, 2020
e-ivaldi
approved these changes
Feb 17, 2020
uglyog
approved these changes
Feb 18, 2020
|
4.0.6 has been released with this fix |
mikahjc
pushed a commit
to mikahjc/pact-jvm
that referenced
this pull request
Mar 2, 2020
…junit-runner-initialization"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1020