fix: Use concise Pact Source descriptions #1015
Merged
+88
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem to solve
Pact provider tests print out overly verbose Pact source descriptions (i.e. use default Kotlin toString) when using a Directory or Pact Broker source.
Steps to reproduce
Seen when running provider tests using Pacts from a directory or Pact-Broker with pact-jvm-provider-junit5 plugin.
Current behavior
Expected behavior
Proposed Fix
Implement description methods for DirectorySource and PactBrokerSource,
instead of having them fallback to default Kotlin toString.
Have PactBrokerLoader resolve system parameters, so PactBrokerSource
shows a valid url instead of ${...} placeholders.
NOTICE
This software was produced for the U. S. Government under Contract No. FA8702-20-C-0001, and is subject to the Rights in Noncommercial Computer Software and Noncommercial Computer Software Documentation Clause DFARS 252.227-7014 (FEB 2014)
Approved for Public Release; Distribution Unlimited. Case Number 19-3203.
(c) 2020 The MITRE Corporation. All Rights Reserved.