fix: BigDecimal comparison should use scale and include BigDecimal.ZERO #1001

Author: Ronald Holshausen

core/matchers/src/main/kotlin/au/com/dius/pact/core/matchers/MatcherExecutor.kt

@@ -239,7 +239,7 @@ fun matchDecimal(actual: Any?): Boolean {
     actual == 0 -> true
     actual is Float -> true
     actual is Double -> true
-    actual is BigDecimal && actual.precision() > 0 -> true
+    actual is BigDecimal && (actual == BigDecimal.ZERO || actual.scale() > 0) -> true
     actual is JsonPrimitive && actual.isNumber -> decimalRegex.matches(actual.toString())
     else -> false
   }
@@ -252,7 +252,7 @@ fun matchInteger(actual: Any?): Boolean {
     actual is Int -> true
     actual is Long -> true
     actual is BigInteger -> true
-    actual is BigDecimal && actual.precision() == 0 -> true
+    actual is BigDecimal && actual.scale() == 0 -> true
     actual is JsonPrimitive && actual.isNumber -> integerRegex.matches(actual.toString())
     else -> false
   }

core/matchers/src/test/groovy/au/com/dius/pact/core/matchers/MatcherExecutorSpec.groovy

@@ -212,7 +212,9 @@ class MatcherExecutorSpec extends Specification {
     100 as int        | true
     100 as long       | true
     100 as BigInteger | true
-
+    100 as BigDecimal | true
+    BigInteger.ZERO   | true
+    BigDecimal.ZERO   | true
   }
 
   @Unroll
@@ -232,7 +234,8 @@ class MatcherExecutorSpec extends Specification {
     100 as int        | false
     100 as long       | false
     100 as BigInteger | false
-
+    BigInteger.ZERO   | false
+    BigDecimal.ZERO   | true
   }
 
 }