fix: Pact server fails for requests that dont have Content-Type header #1008

Author: Ronald Holshausen

core/model/src/main/kotlin/au/com/dius/pact/core/model/ContentType.kt

@@ -30,9 +30,13 @@ data class ContentType(val contentType: String?) {
   fun asMimeType() = parsedContentType?.mimeType ?: contentType
 
   companion object : KLogging() {
+    @JvmStatic
     val UNKNOWN = ContentType("")
+    @JvmStatic
     val TEXT_PLAIN = ContentType("text/plain")
+    @JvmStatic
     val HTML = ContentType("text/html")
+    @JvmStatic
     val JSON = ContentType("application/json")
   }
 }

pact-jvm-server/src/main/scala/au/com/dius/pact/server/Conversions.scala

@@ -40,7 +40,8 @@ object Conversions extends StrictLogging {
   def toPath(uri: String) = new URI(uri).getPath
 
   def toBody(request: HttpRequest[ReceivedMessage], charset: String = "UTF-8") = {
-    val is = if (request.headers(ContentEncoding.GZip.name).contains("gzip")) {
+    val gzip = request.headers(ContentEncoding.GZip.name)
+    val is = if (gzip.hasNext && gzip.next().contains("gzip")) {
       new GZIPInputStream(request.inputStream)
     } else {
       request.inputStream
@@ -50,7 +51,9 @@ object Conversions extends StrictLogging {
 
   def unfilteredRequestToPactRequest(request: HttpRequest[ReceivedMessage]): Request = {
     val headers = toHeaders(request)
-    val contentType = new ContentType(request.headers("Content-Type").next())
+    val contentTypeHeader = request.headers("Content-Type")
+    val contentType = if (contentTypeHeader.hasNext) new ContentType(contentTypeHeader.next())
+      else ContentType.getTEXT_PLAIN
     new Request(request.method, toPath(request.uri), toQuery(request), headers,
       OptionalBody.body(toBody(request).getBytes(contentType.asCharset), contentType))
   }

pact-jvm-server/src/test/groovy/au/com/dius/pact/server/ConversionsSpec.groovy

@@ -0,0 +1,32 @@
+package au.com.dius.pact.server
+
+import au.com.dius.pact.core.model.ContentType
+import au.com.dius.pact.core.model.Request
+import scala.collection.JavaConverters
+import spock.lang.Issue
+import spock.lang.Specification
+import unfiltered.netty.ReceivedMessage
+import unfiltered.request.HttpRequest
+
+class ConversionsSpec extends Specification {
+
+  @Issue('#1008')
+  def 'unfilteredRequestToPactRequest - handles the case where there is no content type header'() {
+    given:
+    def httpRequest = Mock(HttpRequest<ReceivedMessage>) {
+      headers(_) >> JavaConverters.asScalaIterator([].iterator())
+      headerNames() >> JavaConverters.asScalaIterator([].iterator())
+      uri() >> '/'
+      parameterNames() >> JavaConverters.asScalaIterator([].iterator())
+      method() >> 'GET'
+      inputStream() >> new ByteArrayInputStream('BOOH!'.bytes)
+    }
+
+    when:
+    Request request = Conversions$.MODULE$.unfilteredRequestToPactRequest(httpRequest)
+
+    then:
+    request.body.contentType == ContentType.TEXT_PLAIN
+  }
+
+}