Merge pull request #1021 from treatwell/defer-junit-runner-initialization

Defer Runner initialization until it is run

Author: Ronald Holshausen

provider/pact-jvm-provider-junit/src/main/kotlin/au/com/dius/pact/provider/junit/PactRunner.kt

@@ -53,8 +53,20 @@ open class PactRunner<I>(clazz: Class<*>) : ParentRunner<InteractionRunner<I>>(c
 
   private val child = mutableListOf<InteractionRunner<I>>()
   private var valueResolver = SystemPropertyResolver()
+  private val clazz = clazz
+  private var initialized = false
+
+  override fun run(notifier: RunNotifier?) {
+    initialize()
+
+    super.run(notifier)
+  }
+
+  private fun initialize() {
+    if (initialized) {
+      return
+    }
 
-  init {
     if (clazz.getAnnotation(Ignore::class.java) != null) {
       logger.info("Ignore annotation detected, exiting")
     } else {
@@ -110,6 +122,7 @@ open class PactRunner<I>(clazz: Class<*>) : ParentRunner<InteractionRunner<I>>(c
 
       setupInteractionRunners(testClass, pacts, pactLoader)
     }
+    initialized = true
   }
 
   protected open fun setupInteractionRunners(testClass: TestClass, pacts: List<Pact<I>>, pactLoader: PactLoader) {

provider/pact-jvm-provider-junit/src/test/groovy/au/com/dius/pact/provider/junit/FilteredPactRunnerSpec.groovy

@@ -10,6 +10,7 @@ import au.com.dius.pact.provider.junit.loader.PactFilter
 import au.com.dius.pact.provider.junit.loader.PactFolder
 import au.com.dius.pact.provider.junit.target.Target
 import au.com.dius.pact.provider.junit.target.TestTarget
+import org.junit.runner.notification.RunNotifier
 import org.junit.runners.model.InitializationError
 import spock.lang.Specification
 
@@ -189,7 +190,7 @@ class FilteredPactRunnerSpec extends Specification {
   @SuppressWarnings('UnusedObject')
   def 'Throws an initialisation error if all pacts are filtered out'() {
     when:
-    new PactRunner(TestFilterOutAllPactsClass)
+    new PactRunner(TestFilterOutAllPactsClass).run(new RunNotifier())
 
     then:
     thrown(InitializationError)

provider/pact-jvm-provider-junit/src/test/groovy/au/com/dius/pact/provider/junit/PactRunnerSpec.groovy

@@ -10,6 +10,7 @@ import au.com.dius.pact.provider.junit.loader.PactUrl
 import au.com.dius.pact.provider.junit.loader.PactUrlLoader
 import au.com.dius.pact.provider.junit.target.Target
 import au.com.dius.pact.provider.junit.target.TestTarget
+import org.junit.runner.notification.RunNotifier
 import org.junit.runners.model.InitializationError
 import spock.lang.Specification
 
@@ -115,7 +116,7 @@ class PactRunnerSpec extends Specification {
 
   def 'PactRunner throws an exception if there is no @Provider annotation on the test class'() {
     when:
-    new PactRunner(PactRunnerSpec)
+    new PactRunner(PactRunnerSpec).run(new RunNotifier())
 
     then:
     InitializationError e = thrown()
@@ -125,7 +126,7 @@ class PactRunnerSpec extends Specification {
 
   def 'PactRunner throws an exception if there is no pact source'() {
     when:
-    new PactRunner(NoSourceTestClass)
+    new PactRunner(NoSourceTestClass).run(new RunNotifier())
 
     then:
     InitializationError e = thrown()
@@ -134,7 +135,7 @@ class PactRunnerSpec extends Specification {
 
   def 'PactRunner throws an exception if the pact source throws an IO exception'() {
     when:
-    new PactRunner(FailsTestClass)
+    new PactRunner(FailsTestClass).run(new RunNotifier())
 
     then:
     InitializationError e = thrown()
@@ -143,13 +144,26 @@ class PactRunnerSpec extends Specification {
 
   def 'PactRunner throws an exception if there are no pacts to verify'() {
     when:
-    new PactRunner(NoPactsTestClass)
+    new PactRunner(NoPactsTestClass).run(new RunNotifier())
 
     then:
     InitializationError e = thrown()
     e.causes*.message == ['Did not find any pact files for provider Bob']
   }
 
+  def 'PactRunner only initializes once if run() is called multiple times'() {
+    when:
+    def runner = new PactRunner(TestClass)
+    runner.run(new RunNotifier())
+    def children1 = runner.children.clone()
+
+    runner.run(new RunNotifier())
+    def children2 = runner.children.clone()
+
+    then:
+    children1 == children2
+  }
+
   def 'PactRunner does not throw an exception if there are no pacts to verify and @IgnoreNoPactsToVerify'() {
     when:
     new PactRunner(NoPactsIgnoredTestClass)
@@ -169,7 +183,7 @@ class PactRunnerSpec extends Specification {
 
   def 'PactRunner throws an exception if there is both a pact source and pact loader annotation'() {
     when:
-    new PactRunner(BothPactSourceAndPactLoaderTestClass)
+    new PactRunner(BothPactSourceAndPactLoaderTestClass).run(new RunNotifier())
 
     then:
     InitializationError e = thrown()
@@ -179,6 +193,7 @@ class PactRunnerSpec extends Specification {
   def 'PactRunner handles a pact source with a pact loader that takes a class parameter'() {
     when:
     def runner = new PactRunner(PactLoaderWithConstructorParameterTestClass)
+    runner.run(new RunNotifier())
 
     then:
     !runner.children.empty
@@ -187,6 +202,7 @@ class PactRunnerSpec extends Specification {
   def 'PactRunner handles a pact source with a pact loader that does not takes a class parameter'() {
     when:
     def runner = new PactRunner(PactLoaderWithDefaultConstructorClass)
+    runner.run(new RunNotifier())
 
     then:
     !runner.children.empty
@@ -195,6 +211,7 @@ class PactRunnerSpec extends Specification {
   def 'PactRunner loads the pact loader class from the pact loader associated with the pact loader annotation'() {
     when:
     def runner = new PactRunner(TestClass)
+    runner.run(new RunNotifier())
 
     then:
     !runner.children.empty