Skip to content

Commit 5e38e39

Browse files
committedJan 19, 2020
lint fix
1 parent 6ad3871 commit 5e38e39

File tree

2 files changed

+25
-9
lines changed

2 files changed

+25
-9
lines changed
 

‎provider/pact-jvm-provider-junit/src/main/kotlin/au/com/dius/pact/provider/junit/descriptions/DescriptionGenerator.kt

+5-3
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,11 @@ import org.junit.runners.model.TestClass
1111
/**
1212
* Class responsible for building junit tests Description.
1313
*/
14-
class DescriptionGenerator<I : Interaction>(private val testClass: TestClass,
15-
private val pact: Pact<I>,
16-
private val pactSource: PactSource) {
14+
class DescriptionGenerator<I : Interaction>(
15+
private val testClass: TestClass,
16+
private val pact: Pact<I>,
17+
private val pactSource: PactSource
18+
) {
1719

1820
/**
1921
* Builds an instance of junit Description adhering with this logic for building the name:

‎provider/pact-jvm-provider-junit/src/test/groovy/au/com/dius/pact/provider/junit/descriptions/DescriptionGeneratorTest.groovy

+20-6
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,26 @@
11
package au.com.dius.pact.provider.junit.descriptions
22

3-
import au.com.dius.pact.core.model.*
3+
import au.com.dius.pact.core.model.RequestResponseInteraction
4+
import au.com.dius.pact.core.model.RequestResponsePact
5+
import au.com.dius.pact.core.model.BrokerUrlSource
6+
import au.com.dius.pact.core.model.DirectorySource
7+
import au.com.dius.pact.core.model.Request
8+
import au.com.dius.pact.core.model.Response
9+
import au.com.dius.pact.core.model.Provider
10+
import au.com.dius.pact.core.model.Consumer
11+
import au.com.dius.pact.core.model.ProviderState
12+
import au.com.dius.pact.provider.junit.target.HttpTarget
13+
import au.com.dius.pact.provider.junit.target.Target
14+
import au.com.dius.pact.provider.junit.target.TestTarget
415
import org.junit.runners.model.TestClass
516
import spock.lang.Specification
617

718
class DescriptionGeneratorTest extends Specification {
819

20+
@SuppressWarnings('PublicInstanceField')
921
class DescriptionGeneratorTestClass {
22+
@TestTarget
23+
public final Target target = new HttpTarget(8332)
1024
}
1125

1226
private clazz
@@ -25,13 +39,13 @@ class DescriptionGeneratorTest extends Specification {
2539
expect:
2640
def pactSource = new BrokerUrlSource('url', 'url', [:], [:], tag)
2741
def generator = new DescriptionGenerator(clazz, pact, pactSource)
28-
description == generator.generate(interaction).getMethodName()
42+
description == generator.generate(interaction).methodName
2943

3044
where:
3145
tag | description
32-
"master" | "[tag:master] consumer - Upon Interaction 1"
33-
null | "consumer - Upon Interaction 1"
34-
"" | "consumer - Upon Interaction 1"
46+
'master' | '[tag:master] consumer - Upon Interaction 1'
47+
null | 'consumer - Upon Interaction 1'
48+
'' | 'consumer - Upon Interaction 1'
3549
}
3650

3751
def 'when non broker pact source tests name are built correctly'() {
@@ -43,6 +57,6 @@ class DescriptionGeneratorTest extends Specification {
4357
expect:
4458
def pactSource = new DirectorySource(file, [file: pact])
4559
def generator = new DescriptionGenerator(clazz, pact, pactSource)
46-
"consumer - Upon Interaction 1" == generator.generate(interaction).getMethodName()
60+
'consumer - Upon Interaction 1' == generator.generate(interaction).methodName
4761
}
4862
}

0 commit comments

Comments
 (0)