fix: get XML parser to ignore DTDs #973

Ronald Holshausen · Ronald Holshausen · commit 4b2c3f6d2620 · 2019-11-24T09:39:56.000+11:00
diff --git a/core/matchers/src/main/kotlin/au/com/dius/pact/core/matchers/XmlBodyMatcher.kt b/core/matchers/src/main/kotlin/au/com/dius/pact/core/matchers/XmlBodyMatcher.kt
@@ -43,6 +43,8 @@ object XmlBodyMatcher : BodyMatcher, KLogging() {
       val dbFactory = DocumentBuilderFactory.newInstance()
       if (System.getProperty("pact.matching.xml.validating") == "false") {
         dbFactory.isValidating = false
+        dbFactory.setFeature("http://apache.org/xml/features/nonvalidating/load-dtd-grammar", false)
+        dbFactory.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false)
       }
       val dBuilder = dbFactory.newDocumentBuilder()
       val xmlInput = InputSource(StringReader(xmlData))

Original file line number	Diff line number	Diff line change
`@@ -43,6 +43,8 @@ object XmlBodyMatcher : BodyMatcher, KLogging() {`
`43`	`43`	`val dbFactory = DocumentBuilderFactory.newInstance()`
`44`	`44`	`if (System.getProperty("pact.matching.xml.validating") == "false") {`
`45`	`45`	`dbFactory.isValidating = false`
	`46`	`+ dbFactory.setFeature("http://apache.org/xml/features/nonvalidating/load-dtd-grammar", false)`
	`47`	`+ dbFactory.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false)`
`46`	`48`	`}`
`47`	`49`	`val dBuilder = dbFactory.newDocumentBuilder()`
`48`	`50`	`val xmlInput = InputSource(StringReader(xmlData))`