fix: pacticipant version is optional is latest is specified #994

Author: Ronald Holshausen

provider/pact-jvm-provider-gradle/src/main/groovy/au/com/dius/pact/provider/gradle/PactCanIDeployTask.groovy

@@ -39,11 +39,12 @@ class PactCanIDeployTask extends DefaultTask {
       throw new GradleScriptException('The CanIDeploy task requires -Ppacticipant=...', null)
     }
     String pacticipant = project.property(PACTICIPANT)
-    if (!project.hasProperty(PACTICIPANT_VERSION)) {
-      throw new GradleScriptException('The CanIDeploy task requires -PpacticipantVersion=...', null)
-    }
-    String pacticipantVersion = project.property(PACTICIPANT_VERSION)
     Latest latest = setupLatestParam()
+    if ((latest instanceof Latest.UseLatestTag || latest.latest == false) &&
+      !project.hasProperty(PACTICIPANT_VERSION)) {
+      throw new GradleScriptException('The CanIDeploy task requires -PpacticipantVersion=... or -Dlatest=true', null)
+    }
+    String pacticipantVersion = project.hasProperty(PACTICIPANT_VERSION) ? project.property(PACTICIPANT_VERSION) : ''
     String to = null
     if (project.hasProperty(TO)) {
       to = project.property(TO)

provider/pact-jvm-provider-gradle/src/test/groovy/au/com/dius/pact/provider/gradle/PactCanIDeployTaskSpec.groovy

@@ -46,7 +46,7 @@ class PactCanIDeployTaskSpec extends Specification {
     ex.message == 'The CanIDeploy task requires -Ppacticipant=...'
   }
 
-  def 'raises an exception if no pacticipantVersion is provided'() {
+  def 'raises an exception if pacticipantVersion and latest is not provided'() {
     given:
     project.pact {
       broker {
@@ -61,7 +61,29 @@ class PactCanIDeployTaskSpec extends Specification {
 
     then:
     def ex = thrown(GradleScriptException)
-    ex.message == 'The CanIDeploy task requires -PpacticipantVersion=...'
+    ex.message == 'The CanIDeploy task requires -PpacticipantVersion=... or -Dlatest=true'
+  }
+
+  def 'pacticipantVersion can be missing if latest is provided'() {
+    given:
+    project.pact {
+      broker {
+        pactBrokerUrl = 'pactBrokerUrl'
+      }
+    }
+    project.ext.pacticipant = 'pacticipant'
+    project.ext.latest = 'true'
+    project.evaluate()
+
+    task.brokerClient = Mock(PactBrokerClient) {
+      canIDeploy(_, _, _, _) >> new CanIDeployResult(true, '', '')
+    }
+
+    when:
+    task.canIDeploy()
+
+    then:
+    notThrown(GradleScriptException)
   }
 
   def 'calls the pact broker client'() {

provider/pact-jvm-provider-maven/src/main/kotlin/au/com/dius/pact/provider/maven/PactCanIDeployMojo.kt

@@ -44,12 +44,13 @@ open class PactCanIDeployMojo : PactBaseMojo() {
       if (pacticipant.isNullOrEmpty()) {
         throw MojoExecutionException("The can-i-deploy task requires -Dpacticipant=...", null)
       }
-      if (pacticipantVersion.isNullOrEmpty()) {
-        throw MojoExecutionException("The can-i-deploy task requires -DpacticipantVersion=...", null)
-      }
 
       val latest = setupLatestParam()
-      val result = brokerClient!!.canIDeploy(pacticipant!!, pacticipantVersion!!, latest, to)
+      if ((latest !is Latest.UseLatest || !latest.latest) && pacticipantVersion.isNullOrEmpty()) {
+        throw MojoExecutionException("The can-i-deploy task requires -DpacticipantVersion=... or -Dlatest=true", null)
+      }
+
+      val result = brokerClient!!.canIDeploy(pacticipant!!, pacticipantVersion.orEmpty(), latest, to)
       if (result.ok) {
         AnsiConsole.out().println(Ansi.ansi().a("Computer says yes \\o/ ").a(result.message).a("\n\n")
           .fg(Ansi.Color.GREEN).a(result.reason).reset())

provider/pact-jvm-provider-maven/src/test/groovy/au/com/dius/pact/provider/maven/PactCanIDeployMojoSpec.groovy

@@ -41,7 +41,7 @@ class PactCanIDeployMojoSpec extends Specification {
     ex.message == 'The can-i-deploy task requires -Dpacticipant=...'
   }
 
-  def 'throws an exception if pacticipantVersion is not provided'() {
+  def 'throws an exception if pacticipantVersion and latest is not provided'() {
     given:
     mojo.pacticipantVersion = null
 
@@ -50,7 +50,22 @@ class PactCanIDeployMojoSpec extends Specification {
 
     then:
     def ex = thrown(MojoExecutionException)
-    ex.message == 'The can-i-deploy task requires -DpacticipantVersion=...'
+    ex.message == 'The can-i-deploy task requires -DpacticipantVersion=... or -Dlatest=true'
+  }
+
+  def 'pacticipantVersion can be missing if latest is provided'() {
+    given:
+    mojo.pacticipantVersion = null
+    mojo.latest = 'true'
+    mojo.brokerClient = Mock(PactBrokerClient) {
+      canIDeploy(_, _, _, _) >> new CanIDeployResult(true, '', '')
+    }
+
+    when:
+    mojo.execute()
+
+    then:
+    notThrown(MojoExecutionException)
   }
 
   def 'calls the pact broker client'() {