Start supporting pandas >=2.1 #645
Labels
dependencies
Pull requests that update a dependency file
python
Relates to one of the Ribasim python packages
Comments
Merged
visr
added
python
|
2.1.1 didn't fix it, since it still contains a regression, but 2.1.2 might: pandas-dev/pandas#55690 |
visr
added a commit
that referenced
this issue
Oct 31, 2023
Fixes #654 Fixes #645 I ran `pixi add pandas=2.1.2 python=3.12 pyogrio=0.7.2` using pixi v0.5.0 so as not to update the lockfile format. The new pyogrio release is needed to be able to use Python 3.12. We only update the Python version in the Pixi lockfile and on CI, this does not change our minimum supported Python version. The pandas update to 2.1.2 fixes a regression present in 2.1.0 and 2.1.1, no further changes were needed in our code.
Hofer-Julian
pushed a commit
that referenced
this issue
Oct 31, 2023
Part of #654 Fixes #645 I ran `pixi add pandas=2.1.2 python=3.12 pyogrio=0.7.2` using pixi v0.5.0 so as not to update the lockfile format. The new pyogrio release is needed to be able to use Python 3.12. We only update the Python version in the Pixi lockfile and on CI, this does not change our minimum supported Python version. The pandas update to 2.1.2 fixes a regression present in 2.1.0 and 2.1.1, no further changes were needed in our code. @Hofer-Julian I simply removed the `pandas < 2.1` restriction in the pyproject.toml, assuming that is fine since with the release of pandas 2.1.2 most people won't get 2.1.0 or 2.1.1 anymore, though I guess we could exclude multiple patch releases.
visr
added a commit
that referenced
this issue
Nov 13, 2023
Part of #654 Fixes #645 I ran `pixi add pandas=2.1.2 python=3.12 pyogrio=0.7.2` using pixi v0.5.0 so as not to update the lockfile format. The new pyogrio release is needed to be able to use Python 3.12. We only update the Python version in the Pixi lockfile and on CI, this does not change our minimum supported Python version. The pandas update to 2.1.2 fixes a regression present in 2.1.0 and 2.1.1, no further changes were needed in our code. @Hofer-Julian I simply removed the `pandas < 2.1` restriction in the pyproject.toml, assuming that is fine since with the release of pandas 2.1.2 most people won't get 2.1.0 or 2.1.1 anymore, though I guess we could exclude multiple patch releases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
At the moment, Ribasim Python fails with pandas >= 2.1.
We should adapt our code, so it starts working, and remove the version requirement.
Original issue description: #586 (comment)
I assumed 2.1.1 would fix it for us: #643 (comment)
The text was updated successfully, but these errors were encountered: