Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datadog_synthetics_test] Only set renotify_occurrences if renotify_interval is set #2871

Merged

Conversation

Alexis-Jacob-datadog
Copy link
Contributor

@Alexis-Jacob-datadog Alexis-Jacob-datadog commented Feb 25, 2025

Since the merge of #2820, the Terraform provider for the API has been consistently expecting the renotify_interval option. This pull request modifies the behavior to ignore the renotify_occurrences option if the renotify_interval is not set.

@Alexis-Jacob-datadog Alexis-Jacob-datadog marked this pull request as ready for review February 25, 2025 15:28
@Alexis-Jacob-datadog Alexis-Jacob-datadog requested review from a team as code owners February 25, 2025 15:28
@Alexis-Jacob-datadog Alexis-Jacob-datadog marked this pull request as draft February 25, 2025 15:28
@Alexis-Jacob-datadog Alexis-Jacob-datadog marked this pull request as ready for review February 25, 2025 15:29
@Alexis-Jacob-datadog
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 26, 2025

View all feedbacks in Devflow UI.
2025-02-26 14:19:47 UTC ℹ️ Start processing command /merge


2025-02-26 14:19:50 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in master is 3m.


2025-02-26 14:41:20 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 6b3cd75 into master Feb 26, 2025
24 checks passed
@dd-mergequeue dd-mergequeue bot deleted the alexis.jacob/SYNTH/18658-ignore-renotify_occurrences branch February 26, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants