Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sampling): sample floats with zero decimal [backport 2.8] #9038

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 18, 2024

Backport 4653b73 from #8946 to 2.8.

Fixes this system-test after it began running recently, due to a duplicate test of the same name being removed. https://github.com/DataDog/system-tests/actions/runs/8640516929/job/23688605939

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Fixes this system-test after it began running recently, due to a
duplicate test of the same name being removed.
https://github.com/DataDog/system-tests/actions/runs/8640516929/job/23688605939

## Checklist

- [x] Change(s) are motivated and described in the PR description
- [x] Testing strategy is described if automated tests are not included
in the PR
- [x] Risks are described (performance impact, potential for breakage,
maintainability)
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed or label `changelog/no-changelog` is set
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/))
- [x] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
- [x] If this PR changes the public interface, I've notified
`@DataDog/apm-tees`.

## Reviewer Checklist

- [x] Title is accurate
- [x] All changes are related to the pull request's stated goal
- [x] Description motivates each change
- [x] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- [x] Testing strategy adequately addresses listed risks
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] Release note makes sense to a user of the library
- [x] Author has acknowledged and discussed the performance implications
of this PR as reported in the benchmarks PR comment
- [x] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 4653b73)
@github-actions github-actions bot requested review from a team as code owners April 18, 2024 14:59
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Apr 18, 2024

Datadog Report

Branch report: backport-8946-to-2.8
Commit report: cd161fd
Test service: dd-trace-py

✅ 0 Failed, 30764 Passed, 137977 Skipped, 5h 35m 25.12s Total duration (4h 2m 59.43s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Apr 18, 2024

Benchmarks

Benchmark execution time: 2024-04-18 16:03:28

Comparing candidate commit 06f15ac in PR branch backport-8946-to-2.8 with baseline commit 3ef5436 in branch 2.8.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 201 metrics, 9 unstable metrics.

@gnufede gnufede closed this Apr 22, 2024
@gnufede gnufede reopened this Apr 22, 2024
@gnufede gnufede enabled auto-merge (squash) April 22, 2024 07:51
@gnufede gnufede merged commit 7de9217 into 2.8 Apr 22, 2024
168 checks passed
@gnufede gnufede deleted the backport-8946-to-2.8 branch April 22, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants