Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
5
contributors
Commits on Sep 29, 2023
-
fix(profiling): do not leak module entry on purpose (#2291)
This was done in the early days of the move from C to Rust. The goal at the time was to avoid unsafe code, and that was one way of working around specific requirements. This is a different way, still mostly safe code, but will not leak. Note that this wasn't a leak that mattered to anything except tooling. The goal is to soon run an NTS+ASAN build for the profiler, and this would trigger the leak sanitizer (implied by address sanitizer on Linux).
Commits on Oct 3, 2023
-
Fix ZAI config handling for .htaccess with php-fpm (#2298)
When connecting .htaccess via php-fpm, apache will set true environment variables, a circumstance where the handling explicitly calling ZaiConfigOnUpdateIni was skipped, leading to non-updated configs. Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Commits on Oct 4, 2023
-
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> Co-authored-by: Bob Weinand <bob.weinand@datadoghq.com>
-
Commits on Oct 5, 2023
Commits on Oct 6, 2023
Commits on Oct 9, 2023
-
Expand arrays and public properties of objects in meta into nested-ta…
…g format (#2302) This will be required for the display of OpenTelemetry array attributes. Note that this also removes the parenthesis from boolean/null values in order to be consistent with other languages, i.e. system-tests. Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Commits on Oct 12, 2023
-
Subclass SpanData with RootSpanData (#2309)
This allows setting specific data on RootSpans. Further, since properties are always at the end of the zend_object, if RootSpanData has properties, they would conflict with the trailing SpanData members. Hence, they need to be moved in front. Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
-
Explicitly drop dd.p.dm if provided in propagated tags when the incom…
…ing sampling priority is reject (#2310) Beforehand, the tracer would pass _dd.p.dm unfiltered, if it was propagated and sampling priorities not changed. I do think this is the more reasonable behaviour, but complying with system tests here. Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
-
-
Strictly validate dd.p.tid (#2303)
Also ensure consuming trace headers does apply to an existing root span instead of preset if one exists. Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Commits on Oct 16, 2023
-
Report extensions used in telemetry (#2295)
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Commits on Oct 23, 2023
-
-
Refactor tightly coupled extraction state (#2314)
Moving: - distributed state directly to the root span - the extraction logic into its own file, reusable for different purposes (extracting to span, to globals, to span link) - the trace_id to only the root span - the parent id to only the root span; the parent id of any other span is simply the id of the parent span The distributed tracing state is now fully separated between the root span-less (i.e. containing incoming distributed data) and the distributed data tied to a span, allowing it to properly use their own distributed tracing without information leaking across traces. It also adds a small hexId() helper function on SpanData. SpanLink gains a static fromHeaders() function, which works exactly like DDTrace\consume_distributed_tracing_headers(). Adding ddtrace_set_priority_sampling_on_root() as public for an interoperable way to set sampling priority from appsec. Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
-
-
Commits on Oct 24, 2023
-
Add Magento 2 Integration (#2274)
* Generate integration artifact * Add laminas deferred loading on Application::bootstrap * Start the magento integration (wip++) * Play with blocks * Revert "Play with blocks" This reverts commit 2013054. * Play with blocks * Load magento on Magento\Framework\Console\Cli::__construct * Remove some hooks * Trace events * Trace plugins * Comment-out plugins tracing * Add test framework * Update docker images with required PHP extensions * fix: install sodium for PHP 7.2+ * fix: Install intl using pecl (7.0) and downgrade redis to 5.6 * test: Add Magento 2.4 snapshots * fix: only install intl for php 7.1+ * test: Add Magento 2.3 test framework + snapshots + installation instructions * fix: Manually set MySQL 5.6 as supported in Magento 2.4 * test: Remove Magento 2.2 test framework (Notes) Notes: Too old; incompatibility with composer * test: Add ignored Core.php * fix: Give 777 permissions after magento installation * fix: Use sudo to set permissions * test: Ignore 'magento.block.cache_key' * test: Ignore 'meta.magento.block.cache_key' * feat: Use DD_HTTP_SERVER_ROUTE_BASED_NAMING * test: Update snapshots * test: Ignore exception if GD library is not installed * fix: Typo in the IntegrationsLoader * debug: error log nginx config file content * fix: typo * style: Remove semi-colon from magento.area.get if there is no area * style: Refactor using MagentoIntegration::getRealClass * test: General duplication refactor * debug: Check that the nginx process has started and is listening * debug: Add error log * debug: Remove error log * debug: Change nginx-default.conf * debug: Enable DD_TRACE_DEBUG in Laravel 9+ tests * style: lint * debug: Don't run magento tests * Revert "debug: Don't run magento tests" This reverts commit 461a7a5. * debug: Remove Magento 2.3 test framework * debug: Totally remove magento test suites * Revert "debug: Totally remove magento test suites" This reverts commit 8400073. * debug: Remove test files from Magento 2.4 test framework * Revert "debug: Remove Magento 2.3 test framework" This reverts commit b71e00c. * debug: Remove test files from Magento 2.3 test framework * debug: Remove non-necessary files from Magento 2.3 test framework * debug: Error log config content * debug: Use dirname * Revert "debug: Use dirname" This reverts commit 8d711de. * debug: Use the root path instead of a tmp dir * debug: Change the web test order * debug: Change the web test order * debug: Desperate attempts at this point * debug: Remove Magento Test Frameworks * Revert "debug: Remove Magento Test Frameworks" This reverts commit 605e881. * debug: Increase nginx error verbosity level to debug * test: Add a .env to Laravel 8x test framework * test: Add a .env to Laravel 8x test framework * test: Change the Laravel `.env` files * debug: Add debug logs to Laravel 8x * debug: Set open_basedir 🤷 * debug: Remove open_basedir inis * debug: Remove test framekworks * debug: Change laravel .env * Revert "debug: Remove test framekworks" This reverts commit d9e9e40. * ✅ Add .env files to laravel test frameworks (9+) * 🔇 Remove debug logs * ✅ Add .env to Laravel 8 Tests * 🔧 Run the nette 24 test first * 🔧 Change Laravel 8 .env DB info * 🔧 Change Laravel 8 .env DB info * 🔧 Reorder tests * 🔨 Wait for nginx's process to start/terminate * 🔨 Use start instead of run * Increase nginx worker connections * Try to prevent nginx memory issues * Revert the test order changes Note: This workaround doesn't workaround * Play with nginx configurations * Play with nginx configurations * Remove .user.ini files * Remove the magento 2.3 test framework * Increase the memory limit when nginx server is used * Revert "Remove the magento 2.3 test framework" This reverts commit aaed36c. * zip it all * 💚 Add lstat_stat_variation15.phpt to 8.1 xfail list * ♻️ Clean before ready for review * ✨ Load symfony on commands * ✨ Load symfony on Magento cli * ✨ Trace CRON jobs and retrieve user id/email * 📸 Update Magento snapshots * ♻️ Refactor code * 🩹 Replace null coalescings with elvis operators * ✏️ Replace /home/circleci/app by /home/circleci/datadog * ✨ Restrict fullActionName resource name to non-cacheable pages * 📸 Update snapshots * ♻️ Refactor code * ✨ Retrieve order information * Add `magento.event.name` tag to `magento.event.execute` spans
Commits on Oct 26, 2023
Commits on Oct 27, 2023
-
-
Avoid %.*s in places where longer strings are used (#2330)
Before php/php-src@e14fbc8 (i.e. PHP 8.1) strings provided with a max length were always truncated at 500 chars Co-authored-by: Florian Engelhardt <florian.engelhardt@datadoghq.com>
-
Add a configuration flag to disable laravel queue distributed tracing (…
…#2304) * ✨ Add DD_TRACE_LARAVEL_QUEUE_SPAN_LINKS * Log the serialized span links * debug: Nullify EG(exception) during span link generation * Cleanup everything * style: Change the configuration flag name to `DD_TRACE_LARAVEL_QUEUE_DISTRIBUTED_TRACING` * style: Remove debug options + indentation * fix: typo * test: Add a regression test * test: Add another regression test * fix: test formatting rules * fix: revert changes that shouldn't have been made * Simplify a condition * Use SpanLink::fromHeaders --------- Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> Co-authored-by: Bob Weinand <bob.weinand@datadoghq.com>
-
Respect service mapping when propagating for DBM (#2321)
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
-
Laminas RESTful methods handling (#2322)
* fix: Strictly check variable type (See Notes) Note: Fixes "Error thrown in ddtrace's closure defined at /opt/datadog-php/dd-trace-sources/bridge/_generated_integrations.php:4423 for Laminas\View\Renderer\JsonRenderer::render(): Call to a member function getTemplate() on array" * feat: Add error type as resource to `laminas.mvcEvent.setError` spans * style: Clean useless PR changes * feat: Trace RESTful methods and capture ApiProblem as errors * fix: Don't use obstart (too risky) * test: Add REST endpoints tests * test: Push phpunit.xml * fix: Handle absent Laminas Mvc Application * test: Set 755 permissions on data/cache dir post-autoload dump * test: Push data/cache/.gitkeep * test: Replace /home/circleci/app by /home/circleci/datadog * test: Run ApiTools tests for php 8.0+ * test: Separate ApiTools tests from Laminas Framework Tests
-
Expand arrays in metrics into nested-tag format (#2333)
* feat: Handle nested args in metrics array * fix: Mistake in Cmd+C, Cmd+V :)
Commits on Oct 28, 2023
-
Add release notes for 0.93.0 (#2337)
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
There are no files selected for viewing