Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Next.js 10.x Tests #3650

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Fix Next.js 10.x Tests #3650

merged 1 commit into from
Sep 22, 2023

Conversation

sabrenner
Copy link
Collaborator

@sabrenner sabrenner commented Sep 21, 2023

What does this PR do?

Fixes unit tests for Next.js 10.x versions

Motivation

Trying to clean up Next.js TODOs, and since we still support this version with our 3.x line (since it uses Node 16), it was worth addressing this one just to make sure we aren't failing any tests

Additional Notes

The 10.x tests won't run here, as they only run on the 3.x release line. They pass locally (with both Node 16 and 18) with these changes, and if any change is needed for CI, it might just be a small timeout bump in the setTimeout.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@sabrenner sabrenner added semver-patch integration-nextjs issues relating to the Next.js framework from Vercel labels Sep 21, 2023
@github-actions
Copy link

Overall package size

Self size: 5.21 MB
Deduped: 60.7 MB
No deduping: 60.87 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.5.0 14.86 MB 14.86 MB
@datadog/native-appsec 4.0.0 14.83 MB 14.83 MB
@datadog/pprof 3.2.0 10.8 MB 11.64 MB
protobufjs 7.2.4 2.74 MB 6.52 MB
@datadog/native-iast-rewriter 2.1.3 2.23 MB 2.32 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.4.2 41.4 kB 704.79 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
retry 0.13.1 18.85 kB 18.85 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #3650 (a4dbaf2) into master (4c05491) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3650   +/-   ##
=======================================
  Coverage   84.78%   84.78%           
=======================================
  Files         219      219           
  Lines        8962     8962           
  Branches       33       33           
=======================================
  Hits         7598     7598           
  Misses       1364     1364           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sabrenner sabrenner marked this pull request as ready for review September 21, 2023 18:22
@sabrenner sabrenner requested review from a team as code owners September 21, 2023 18:22
@sabrenner sabrenner requested a review from jbertran September 21, 2023 18:22
@sabrenner sabrenner merged commit 158b1e6 into master Sep 22, 2023
@sabrenner sabrenner deleted the sabrenner/nextjs-10.x-tests branch September 22, 2023 15:22
khanayan123 pushed a commit that referenced this pull request Sep 26, 2023
khanayan123 pushed a commit that referenced this pull request Sep 26, 2023
khanayan123 pushed a commit that referenced this pull request Sep 26, 2023
khanayan123 pushed a commit that referenced this pull request Sep 26, 2023
khanayan123 pushed a commit that referenced this pull request Sep 27, 2023
khanayan123 pushed a commit that referenced this pull request Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-nextjs issues relating to the Next.js framework from Vercel semver-patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants