-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Next.js 10.x Tests #3650
Merged
Merged
Fix Next.js 10.x Tests #3650
+10
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabrenner
added
semver-patch
integration-nextjs
issues relating to the Next.js framework from Vercel
labels
Sep 21, 2023
Overall package sizeSelf size: 5.21 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #3650 +/- ##
=======================================
Coverage 84.78% 84.78%
=======================================
Files 219 219
Lines 8962 8962
Branches 33 33
=======================================
Hits 7598 7598
Misses 1364 1364 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
juan-fernandez
approved these changes
Sep 22, 2023
khanayan123
pushed a commit
that referenced
this pull request
Sep 26, 2023
khanayan123
pushed a commit
that referenced
this pull request
Sep 26, 2023
khanayan123
pushed a commit
that referenced
this pull request
Sep 26, 2023
khanayan123
pushed a commit
that referenced
this pull request
Sep 26, 2023
khanayan123
pushed a commit
that referenced
this pull request
Sep 27, 2023
khanayan123
pushed a commit
that referenced
this pull request
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes unit tests for Next.js 10.x versions
Motivation
Trying to clean up Next.js TODOs, and since we still support this version with our 3.x line (since it uses Node 16), it was worth addressing this one just to make sure we aren't failing any tests
Additional Notes
The 10.x tests won't run here, as they only run on the 3.x release line. They pass locally (with both Node 16 and 18) with these changes, and if any change is needed for CI, it might just be a small timeout bump in the
setTimeout
.