Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setters to configure the global instance #790

Merged
merged 2 commits into from
Sep 1, 2023
Merged

Conversation

vickenty
Copy link
Contributor

What does this PR do?

Make it possible to enable new features from #787 on the global statsd instance.

Description of the Change

Add setter methods to modify socket timeout and start the background sender thread.

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

Sorry, something went wrong.

@vickenty vickenty added the changelog/no-changelog Changes don't appear in changelog label Aug 23, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@vickenty vickenty marked this pull request as ready for review August 23, 2023 14:10
@vickenty vickenty requested review from a team as code owners August 23, 2023 14:10
@vickenty vickenty merged commit 52a23f8 into master Sep 1, 2023
@vickenty vickenty deleted the vickenty/global branch September 1, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog Changes don't appear in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants